Changeset 79919 in webkit


Ignore:
Timestamp:
Feb 28, 2011 2:09:45 PM (13 years ago)
Author:
inferno@chromium.org
Message:

2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79425.
http://trac.webkit.org/changeset/79425
https://bugs.webkit.org/show_bug.cgi?id=55406

Incorrect canvas fallback implementation. (Requested by
inferno-sec on #webkit).

  • canvas/canvas-mouse-events-expected.txt: Removed.
  • canvas/canvas-mouse-events.html: Removed.
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win-wk2/Skipped:

2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79425.
http://trac.webkit.org/changeset/79425
https://bugs.webkit.org/show_bug.cgi?id=55406

Incorrect canvas fallback implementation. (Requested by
inferno-sec on #webkit).

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::nodeAtPoint):
Location:
trunk
Files:
2 deleted
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r79917 r79919  
     12011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r79425.
     4        http://trac.webkit.org/changeset/79425
     5        https://bugs.webkit.org/show_bug.cgi?id=55406
     6
     7        Incorrect canvas fallback implementation. (Requested by
     8        inferno-sec on #webkit).
     9
     10        * canvas/canvas-mouse-events-expected.txt: Removed.
     11        * canvas/canvas-mouse-events.html: Removed.
     12        * platform/mac-wk2/Skipped:
     13        * platform/qt-wk2/Skipped:
     14        * platform/win-wk2/Skipped:
     15
    1162011-02-28  Adam Klein  <adamk@chromium.org>
    217
  • trunk/LayoutTests/platform/mac-wk2/Skipped

    r79455 r79919  
    6161svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html
    6262svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html
    63 canvas/canvas-mouse-events.html
    6463fast/forms/file-input-hit-test.html
    6564fast/repaint/slider-thumb-drag-release.html
  • trunk/LayoutTests/platform/qt-wk2/Skipped

    r79425 r79919  
    114114svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop.html
    115115svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop.html
    116 canvas/canvas-mouse-events.html
    117116compositing/iframes/layout-on-compositing-change.html
    118117editing/deleting/5390681-2.html
  • trunk/LayoutTests/platform/win-wk2/Skipped

    r79425 r79919  
    5353# WebKitTestRunner needs an implementation of eventSender
    5454# <https://bugs.webkit.org/show_bug.cgi?id=42194>
    55 canvas/canvas-mouse-events.html
    5655platform/win/editing/selection/shift-page-up-down.html
    5756platform/win/fast/events/alt-numpad.html
  • trunk/Source/WebCore/ChangeLog

    r79917 r79919  
     12011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r79425.
     4        http://trac.webkit.org/changeset/79425
     5        https://bugs.webkit.org/show_bug.cgi?id=55406
     6
     7        Incorrect canvas fallback implementation. (Requested by
     8        inferno-sec on #webkit).
     9
     10        * rendering/RenderHTMLCanvas.cpp:
     11        (WebCore::RenderHTMLCanvas::nodeAtPoint):
     12
    1132011-02-28  Adam Klein  <adamk@chromium.org>
    214
  • trunk/Source/WebCore/rendering/RenderHTMLCanvas.cpp

    r79425 r79919  
    103103}
    104104
    105 bool RenderHTMLCanvas::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, int xPos, int yPos, int tx, int ty, HitTestAction action)
     105bool RenderHTMLCanvas::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, int x, int y, int tx, int ty, HitTestAction action)
    106106{
    107107    UNUSED_PARAM(request);
    108     tx += x();
    109     ty += y();
    110 
    111     // Ignore children (accessible fallback content that might be focusable but not clickable)
    112     // but do test our own bounds for a hit.
    113     IntRect boundsRect = IntRect(tx, ty, width(), height());
    114     if (visibleToHitTesting() && action == HitTestForeground && boundsRect.intersects(result.rectForPoint(xPos, yPos))) {
    115         updateHitTestResult(result, IntPoint(xPos - tx, yPos - ty));
    116         if (!result.addNodeToRectBasedTestResult(node(), xPos, yPos, boundsRect))
    117             return true;
    118     }
    119 
     108    UNUSED_PARAM(result);
     109    UNUSED_PARAM(x);
     110    UNUSED_PARAM(y);
     111    UNUSED_PARAM(tx);
     112    UNUSED_PARAM(ty);
     113    UNUSED_PARAM(action);
    120114    return false;
    121115}
Note: See TracChangeset for help on using the changeset viewer.