Changeset 80019 in webkit

Timestamp:

Mar 1, 2011 12:02:51 PM (13 years ago)

Author:

Adam Roben

Message:

Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit

Fixes <​http://webkit.org/b/55492> Web process crashes aren't counted toward the
--exit-after-n-crashes-or-timeouts limit

Reviewed by David Kilzer.

• Scripts/old-run-webkit-tests:

(stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
the number of tests that caused the web process to crash when exiting early.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/old-run-webkit-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-01  Adam Roben  <aroben@apple.com>
+
+        Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
+
+        Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
+        --exit-after-n-crashes-or-timeouts limit
+
+        Reviewed by David Kilzer.
+
+        * Scripts/old-run-webkit-tests:
+        (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
+        the number of tests that caused the web process to crash when exiting early.
+
 2011-03-01  Adam Roben  <aroben@apple.com>
 

trunk/Tools/Scripts/old-run-webkit-tests

@@ -2563 +2563 @@
 
     my $crashCount = $counts{crash} || 0;
+    my $webProcessCrashCount = $counts{webProcessCrash} || 0;
     my $timeoutCount = $counts{timedout} || 0;
-    if ($exitAfterNCrashesOrTimeouts && $crashCount + $timeoutCount >= $exitAfterNCrashesOrTimeouts) {
-        print "\nExiting early after $crashCount crashes and $timeoutCount timeouts. $count tests run.";
+    if ($exitAfterNCrashesOrTimeouts && $crashCount + $webProcessCrashCount + $timeoutCount >= $exitAfterNCrashesOrTimeouts) {
+        print "\nExiting early after $crashCount crashes, $webProcessCrashCount web process crashes, and $timeoutCount timeouts. $count tests run.";
         closeDumpTool();
         return 1;