Changeset 80143 in webkit

Timestamp:

Mar 2, 2011 10:03:02 AM (13 years ago)

Author:

sergio@webkit.org

Message:

2011-03-02 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add support for external protocol handlers
​https://bugs.webkit.org/show_bug.cgi?id=55473

Do not unconditionally create and replace the SoupRequester of the
SoupSession if there is already one. No new tests needed as we
just allow clients to create their our SoupRequesters.

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-02  Sergio Villar Senin  <svillar@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add support for external protocol handlers
+        https://bugs.webkit.org/show_bug.cgi?id=55473
+
+        Do not unconditionally create and replace the SoupRequester of the
+        SoupSession if there is already one. No new tests needed as we
+        just allow clients to create their our SoupRequesters.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::ensureSessionIsInitialized):
+
 2011-03-02  John Knottenbelt  <jknotten@chromium.org>
 

trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -172 +172 @@
     }
 
-    SoupRequester* requester = soup_requester_new();
-    soup_session_add_feature(session, SOUP_SESSION_FEATURE(requester));
-    g_object_unref(requester);
+    if (!soup_session_get_feature(session, SOUP_TYPE_REQUESTER)) {
+        SoupRequester* requester = soup_requester_new();
+        soup_session_add_feature(session, SOUP_SESSION_FEATURE(requester));
+        g_object_unref(requester);
+    }
 
     g_object_set(session,