Changeset 80243 in webkit

Timestamp:

Mar 3, 2011 8:42:49 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

2011-03-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
​https://bugs.webkit.org/show_bug.cgi?id=53960

• platform/gtk/Skipped: Unskip fast/events/popup-blocking-click-in-iframe.html that passes now.

2011-03-03 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
​https://bugs.webkit.org/show_bug.cgi?id=53960

• DumpRenderTree/gtk/EventSender.cpp: (sendClick): (scheduleAsynchronousClickCallback):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/EventSender.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
+        https://bugs.webkit.org/show_bug.cgi?id=53960
+
+        * platform/gtk/Skipped: Unskip
+        fast/events/popup-blocking-click-in-iframe.html that passes now.
+
 2011-03-03  Martin Robinson  <mrobinson@igalia.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -398 +398 @@
 # Missing output when page icon changes. We need some API exposing this event.
 fast/dom/icon-url-property.html
-
-# EventSender.scheduleAsynchronousClick unimplemented
-# https://bugs.webkit.org/show_bug.cgi?id=53960 
-fast/events/popup-blocking-click-in-iframe.html
 
 # Looks like a bug in the LayoutTestController global history support due to missing API.

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
+        https://bugs.webkit.org/show_bug.cgi?id=53960
+
+        * DumpRenderTree/gtk/EventSender.cpp:
+        (sendClick):
+        (scheduleAsynchronousClickCallback):
+
 2011-03-03  Adam Roben  <aroben@apple.com>
 

trunk/Tools/DumpRenderTree/gtk/EventSender.cpp

@@ -228 +228 @@
     sendOrQueueEvent(releaseEvent);
     return valueRef;
+}
+
+static gboolean sendClick(gpointer)
+{
+    GdkEvent* pressEvent = gdk_event_new(GDK_BUTTON_PRESS);
+
+    if (!prepareMouseButtonEvent(pressEvent, 1, 0)) {
+        gdk_event_free(pressEvent);
+        return FALSE;
+    }
+
+    GdkEvent* releaseEvent = gdk_event_copy(pressEvent);
+    dispatchEvent(pressEvent);
+    releaseEvent->type = GDK_BUTTON_RELEASE;
+    dispatchEvent(releaseEvent);
+
+    return FALSE;
+}
+
+static JSValueRef scheduleAsynchronousClickCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
+{
+    g_idle_add(sendClick, 0);
+    return JSValueMakeUndefined(context);
 }
 
@@ -779 +802 @@
     { "zoomPageIn", zoomPageInCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
     { "zoomPageOut", zoomPageOutCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
+    { "scheduleAsynchronousClick", scheduleAsynchronousClickCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
     { 0, 0, 0 }
 };