Changeset 80298 in webkit


Ignore:
Timestamp:
Mar 3, 2011 4:49:21 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

2011-03-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Martin Robinson.

Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=52742

Use firstPositionInOrBeforeNode to instantiate appropriate position.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder):
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r80297 r80298  
     12011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Reviewed by Martin Robinson.
     4
     5        Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
     6        https://bugs.webkit.org/show_bug.cgi?id=52742
     7
     8        Use firstPositionInOrBeforeNode to instantiate appropriate position.
     9
     10        * page/FocusController.cpp:
     11        (WebCore::FocusController::advanceFocusInDocumentOrder):
     12
    1132011-03-03  Andy Estes  <aestes@apple.com>
    214
  • trunk/Source/WebCore/page/FocusController.cpp

    r79196 r80298  
    5656#include "SpatialNavigation.h"
    5757#include "Widget.h"
     58#include "htmlediting.h" // For firstPositionInOrBeforeNode
    5859
    5960namespace WebCore {
     
    288289
    289290    if (caretBrowsing) {
    290         VisibleSelection newSelection(Position(node, 0), Position(node, 0), DOWNSTREAM);
     291        Position position = firstPositionInOrBeforeNode(node);
     292        VisibleSelection newSelection(position, position, DOWNSTREAM);
    291293        if (frame->selection()->shouldChangeSelection(newSelection))
    292294            frame->selection()->setSelection(newSelection);
Note: See TracChangeset for help on using the changeset viewer.