Changeset 80354 in webkit

Timestamp:

Mar 4, 2011 8:25:20 AM (13 years ago)

Author:

caseq@chromium.org

Message:

2011-03-04 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: exceptions when building context menu in network panel
​https://bugs.webkit.org/show_bug.cgi?id=55678

• inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.dataGridNodeFromNode): (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DataGrid.js (modified) (2 diffs)
• inspector/front-end/NetworkPanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: exceptions when building context menu in network panel
+        https://bugs.webkit.org/show_bug.cgi?id=55678
+
+        * inspector/front-end/DataGrid.js:
+        (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
+        (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype._contextMenu):
+
 2011-03-04  Ilya Sherman  <isherman@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DataGrid.js

@@ -810 +810 @@
     {
         var rowElement = target.enclosingNodeOrSelfWithNodeName("tr");
-        return rowElement._dataGridNode;
+        return rowElement && rowElement._dataGridNode;
     },
 
@@ -817 +817 @@
         var node = this._dataTable.ownerDocument.elementFromPoint(x, y);
         var rowElement = node.enclosingNodeOrSelfWithNodeName("tr");
-        return rowElement._dataGridNode;
+        return rowElement && rowElement._dataGridNode;
     },
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -973 +973 @@
     {
         // createBlobURL is enabled conditionally, do not expose resource export if it's not available.
-        if (typeof window.webkitURL.createObjectURL !== "function" || !Preferences.resourceExportEnabled)
+        if ((window.webkitURL && typeof window.webkitURL.createObjectURL !== "function") || !Preferences.resourceExportEnabled)
             return;