Changeset 80362 in webkit
- Timestamp:
- Mar 4, 2011 9:38:24 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 13 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r80361 r80362 1 2011-03-04 Patrick Gansterer <paroga@webkit.org> 2 3 Reviewed by Nikolas Zimmermann. 4 5 Move shared code into SVGStyledTransformableElement::svgAttributeChanged 6 https://bugs.webkit.org/show_bug.cgi?id=55771 7 8 All sub classes of SVGStyledTransformableElement request a relayout 9 the same way. So move that code into the common base class. 10 11 * svg/SVGCircleElement.cpp: 12 (WebCore::SVGCircleElement::svgAttributeChanged): 13 * svg/SVGEllipseElement.cpp: 14 (WebCore::SVGEllipseElement::svgAttributeChanged): 15 * svg/SVGForeignObjectElement.cpp: 16 (WebCore::SVGForeignObjectElement::svgAttributeChanged): 17 * svg/SVGGElement.cpp: 18 (WebCore::SVGGElement::svgAttributeChanged): 19 * svg/SVGImageElement.cpp: 20 (WebCore::SVGImageElement::svgAttributeChanged): 21 * svg/SVGLineElement.cpp: 22 (WebCore::SVGLineElement::svgAttributeChanged): 23 * svg/SVGPathElement.cpp: 24 (WebCore::SVGPathElement::svgAttributeChanged): 25 * svg/SVGPolyElement.cpp: 26 (WebCore::SVGPolyElement::svgAttributeChanged): 27 * svg/SVGRectElement.cpp: 28 (WebCore::SVGRectElement::svgAttributeChanged): 29 * svg/SVGStyledTransformableElement.cpp: 30 (WebCore::SVGStyledTransformableElement::svgAttributeChanged): 31 * svg/SVGStyledTransformableElement.h: 32 * svg/SVGUseElement.cpp: 33 (WebCore::SVGUseElement::svgAttributeChanged): 34 1 35 2011-03-03 John Abd-El-Malek <jam@chromium.org> 2 36 -
trunk/Source/WebCore/svg/SVGCircleElement.cpp
r78345 r80362 91 91 return; 92 92 93 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {94 renderer->setNeedsTransformUpdate();95 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);96 return;97 }98 99 93 if (isLengthAttribute) { 100 94 renderer->setNeedsPathUpdate(); -
trunk/Source/WebCore/svg/SVGEllipseElement.cpp
r78345 r80362 98 98 return; 99 99 100 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {101 renderer->setNeedsTransformUpdate();102 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);103 return;104 }105 106 100 if (isLengthAttribute) { 107 101 renderer->setNeedsPathUpdate(); -
trunk/Source/WebCore/svg/SVGForeignObjectElement.cpp
r78345 r80362 97 97 return; 98 98 99 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {100 renderer->setNeedsTransformUpdate();101 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);102 return;103 }104 105 99 if (isLengthAttribute 106 100 || SVGLangSpace::isKnownAttribute(attrName) -
trunk/Source/WebCore/svg/SVGGElement.cpp
r79155 r80362 67 67 return; 68 68 69 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {70 renderer->setNeedsTransformUpdate();71 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);72 return;73 }74 75 69 if (SVGLangSpace::isKnownAttribute(attrName) 76 70 || SVGExternalResourcesRequired::isKnownAttribute(attrName)) -
trunk/Source/WebCore/svg/SVGImageElement.cpp
r78345 r80362 113 113 return; 114 114 115 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {116 renderer->setNeedsTransformUpdate();117 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);118 return;119 }120 121 115 if (isLengthAttribute) { 122 116 renderer->updateFromElement(); -
trunk/Source/WebCore/svg/SVGLineElement.cpp
r78345 r80362 94 94 return; 95 95 96 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {97 renderer->setNeedsTransformUpdate();98 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);99 return;100 }101 102 96 if (isLengthAttribute) { 103 97 renderer->setNeedsPathUpdate(); -
trunk/Source/WebCore/svg/SVGPathElement.cpp
r78345 r80362 231 231 return; 232 232 233 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {234 renderer->setNeedsTransformUpdate();235 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);236 return;237 }238 239 233 if (attrName == SVGNames::pathLengthAttr 240 234 || SVGLangSpace::isKnownAttribute(attrName) -
trunk/Source/WebCore/svg/SVGPolyElement.cpp
r78345 r80362 77 77 return; 78 78 79 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {80 renderer->setNeedsTransformUpdate();81 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);82 return;83 }84 85 79 if (attrName == SVGNames::pointsAttr) { 86 80 renderer->setNeedsPathUpdate(); -
trunk/Source/WebCore/svg/SVGRectElement.cpp
r78345 r80362 111 111 return; 112 112 113 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {114 renderer->setNeedsTransformUpdate();115 RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer);116 return;117 }118 119 113 if (isLengthAttribute) { 120 114 renderer->setNeedsPathUpdate(); -
trunk/Source/WebCore/svg/SVGStyledTransformableElement.cpp
r78345 r80362 27 27 #include "Attribute.h" 28 28 #include "RenderSVGPath.h" 29 #include "RenderSVGResource.h" 29 30 #include "SVGNames.h" 30 31 … … 81 82 } 82 83 84 void SVGStyledTransformableElement::svgAttributeChanged(const QualifiedName& attrName) 85 { 86 SVGStyledLocatableElement::svgAttributeChanged(attrName); 87 88 if (!SVGStyledTransformableElement::isKnownAttribute(attrName)) 89 return; 90 91 RenderObject* object = renderer(); 92 if (!object) 93 return; 94 95 object->setNeedsTransformUpdate(); 96 RenderSVGResource::markForLayoutAndParentResourceInvalidation(object); 97 } 98 83 99 void SVGStyledTransformableElement::synchronizeProperty(const QualifiedName& attrName) 84 100 { -
trunk/Source/WebCore/svg/SVGStyledTransformableElement.h
r78345 r80362 59 59 60 60 virtual void parseMappedAttribute(Attribute*); 61 virtual void svgAttributeChanged(const QualifiedName&); 61 62 virtual void synchronizeProperty(const QualifiedName&); 62 63 void fillPassedAttributeToPropertyTypeMap(AttributeToPropertyTypeMap&); -
trunk/Source/WebCore/svg/SVGUseElement.cpp
r79155 r80362 186 186 } 187 187 188 if (SVGStyledTransformableElement::isKnownAttribute(attrName)) {189 object->setNeedsTransformUpdate();190 RenderSVGResource::markForLayoutAndParentResourceInvalidation(object);191 return;192 }193 194 188 if (SVGLangSpace::isKnownAttribute(attrName) 195 189 || SVGExternalResourcesRequired::isKnownAttribute(attrName))
Note: See TracChangeset
for help on using the changeset viewer.