Changeset 80468 in webkit

Timestamp:

Mar 7, 2011 7:38:43 AM (13 years ago)

Author:

andreip@google.com

Message:

2011-03-07 Andrei Popescu <​andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
IDBObjectStore objects used to be created asynchronously, so we needed
this method to be invoked, with the new object store as the parameter,
whenever the creation succeeded. The spec has changed so that IDBObjectStore
objects are created synchronously, so this method is no longer needed.
​https://bugs.webkit.org/show_bug.cgi?id=55777

No new tests, just refactoring.

• storage/IDBCallbacks.h:
• storage/IDBRequest.cpp:
• storage/IDBRequest.h:

2011-03-07 Andrei Popescu <​andreip@google.com>

Reviewed by Steve Block.

IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
​https://bugs.webkit.org/show_bug.cgi?id=55777

• src/IDBCallbacksProxy.cpp:
• src/IDBCallbacksProxy.h:
• src/WebIDBCallbacksImpl.cpp:
• src/WebIDBCallbacksImpl.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/storage/IDBCallbacks.h (modified) (1 diff)
• WebCore/storage/IDBRequest.cpp (modified) (2 diffs)
• WebCore/storage/IDBRequest.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/IDBCallbacksProxy.cpp (modified) (2 diffs)
• WebKit/chromium/src/IDBCallbacksProxy.h (modified) (1 diff)
• WebKit/chromium/src/WebIDBCallbacksImpl.cpp (modified) (3 diffs)
• WebKit/chromium/src/WebIDBCallbacksImpl.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-07  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Steve Block.
+
+        IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
+        IDBObjectStore objects used to be created asynchronously, so we needed
+        this method to be invoked, with the new object store as the parameter,
+        whenever the creation succeeded. The spec has changed so that IDBObjectStore
+        objects are created synchronously, so this method is no longer needed.
+        https://bugs.webkit.org/show_bug.cgi?id=55777
+
+        No new tests, just refactoring.
+
+        * storage/IDBCallbacks.h:
+        * storage/IDBRequest.cpp:
+        * storage/IDBRequest.h:
+
 2011-03-04  Steve Block  <steveblock@google.com>
 

trunk/Source/WebCore/storage/IDBCallbacks.h

@@ -54 +54 @@
     virtual void onSuccess(PassRefPtr<IDBIndexBackendInterface>) = 0;
     virtual void onSuccess(PassRefPtr<IDBKey>) = 0;
-    virtual void onSuccess(PassRefPtr<IDBObjectStoreBackendInterface>) = 0;
     virtual void onSuccess(PassRefPtr<IDBTransactionBackendInterface>) = 0;
     virtual void onSuccess(PassRefPtr<SerializedScriptValue>) = 0;

trunk/Source/WebCore/storage/IDBRequest.cpp

@@ -41 +41 @@
 #include "IDBEventDispatcher.h"
 #include "IDBIndex.h"
-#include "IDBObjectStore.h"
 #include "IDBPendingTransactionMonitor.h"
 #include "IDBTransaction.h"
@@ -217 +216 @@
     m_result = IDBAny::create(idbKey);
     enqueueEvent(createSuccessEvent());
-}
-
-void IDBRequest::onSuccess(PassRefPtr<IDBObjectStoreBackendInterface> backend)
-{
-    ASSERT_NOT_REACHED(); // FIXME: This method should go away.
 }
 

trunk/Source/WebCore/storage/IDBRequest.h

@@ -79 +79 @@
     virtual void onSuccess(PassRefPtr<IDBIndexBackendInterface>);
     virtual void onSuccess(PassRefPtr<IDBKey>);
-    virtual void onSuccess(PassRefPtr<IDBObjectStoreBackendInterface>);
     virtual void onSuccess(PassRefPtr<IDBTransactionBackendInterface>);
     virtual void onSuccess(PassRefPtr<SerializedScriptValue>);

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-03-07  Andrei Popescu  <andreip@google.com>
+
+        Reviewed by Steve Block.
+
+        IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
+        https://bugs.webkit.org/show_bug.cgi?id=55777
+
+        * src/IDBCallbacksProxy.cpp:
+        * src/IDBCallbacksProxy.h:
+        * src/WebIDBCallbacksImpl.cpp:
+        * src/WebIDBCallbacksImpl.h:
+
 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/chromium/src/IDBCallbacksProxy.cpp

@@ -38 +38 @@
 #include "WebIDBIndexImpl.h"
 #include "WebIDBKey.h"
-#include "WebIDBObjectStoreImpl.h"
 #include "WebIDBTransactionImpl.h"
 #include "WebSerializedScriptValue.h"
@@ -85 +84 @@
 }
 
-void IDBCallbacksProxy::onSuccess(PassRefPtr<IDBObjectStoreBackendInterface> backend)
-{
-    m_callbacks->onSuccess(new WebKit::WebIDBObjectStoreImpl(backend));
-}
-
 void IDBCallbacksProxy::onSuccess(PassRefPtr<IDBTransactionBackendInterface> backend)
 {

trunk/Source/WebKit/chromium/src/IDBCallbacksProxy.h

@@ -53 +53 @@
     virtual void onSuccess(PassRefPtr<IDBIndexBackendInterface>);
     virtual void onSuccess(PassRefPtr<IDBKey>);
-    virtual void onSuccess(PassRefPtr<IDBObjectStoreBackendInterface>);
     virtual void onSuccess(PassRefPtr<IDBTransactionBackendInterface>);
     virtual void onSuccess(PassRefPtr<SerializedScriptValue>);

trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp

@@ -33 +33 @@
 #include "IDBIndexBackendProxy.h"
 #include "IDBKey.h"
-#include "IDBObjectStoreProxy.h"
 #include "IDBTransactionBackendProxy.h"
 #include "WebIDBCallbacks.h"
@@ -40 +39 @@
 #include "WebIDBIndex.h"
 #include "WebIDBKey.h"
-#include "WebIDBObjectStore.h"
 #include "WebIDBTransaction.h"
 #include "WebSerializedScriptValue.h"
@@ -82 +80 @@
 }
 
-void WebIDBCallbacksImpl::onSuccess(WebKit::WebIDBObjectStore* webKitInstance)
-{
-    m_callbacks->onSuccess(IDBObjectStoreProxy::create(webKitInstance));
-}
-
 void WebIDBCallbacksImpl::onSuccess(WebKit::WebIDBTransaction* webKitInstance)
 {

trunk/Source/WebKit/chromium/src/WebIDBCallbacksImpl.h

@@ -47 +47 @@
     virtual void onSuccess(const WebKit::WebIDBKey&);
     virtual void onSuccess(WebKit::WebIDBIndex*);
-    virtual void onSuccess(WebKit::WebIDBObjectStore*);
     virtual void onSuccess(WebKit::WebIDBTransaction*);
     virtual void onSuccess(const WebKit::WebSerializedScriptValue&);