Changeset 80546 in webkit

Timestamp:

Mar 8, 2011 12:10:04 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-03-08 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
​https://bugs.webkit.org/show_bug.cgi?id=55878

Enable a passing test now that we properly use the quality value when requesting
a GdkPixbuf to be saved into a buffer.

• platform/gtk/Skipped:

2011-03-08 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
​https://bugs.webkit.org/show_bug.cgi?id=55878

Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
when saving GdkPixbuf to a buffer.

• platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-08  Zan Dobersek  <zandobersek@gmail.com>
+
+        Reviewed by Martin Robinson.
+
+        [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
+        https://bugs.webkit.org/show_bug.cgi?id=55878
+
+        Enable a passing test now that we properly use the quality value when requesting
+        a GdkPixbuf to be saved into a buffer.
+
+        * platform/gtk/Skipped:
+
 2011-03-07  Fumitoshi Ukai  <ukai@chromium.org>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -1002 +1002 @@
 canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html
 canvas/philip/tests/2d.pattern.paint.repeaty.outside.html
-canvas/philip/tests/toDataURL.jpeg.quality.basic.html
 
 # Failing tests after sync with Philip Taylor's upstream tests

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-08  Zan Dobersek  <zandobersek@gmail.com>
+
+        Reviewed by Martin Robinson.
+
+        [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
+        https://bugs.webkit.org/show_bug.cgi?id=55878
+
+        Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
+        when saving GdkPixbuf to a buffer.
+
+        * platform/graphics/gtk/ImageBufferGtk.cpp:
+        (WebCore::ImageBuffer::toDataURL):
+
 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
 

trunk/Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp

@@ -55 +55 @@
     gboolean success = FALSE;
     if (type == "jpeg" && quality && *quality >= 0.0 && *quality <= 1.0) {
-        String qualityString = String::format("%f", *quality);
+        String qualityString = String::format("%f", *quality * 100.0);
         success = gdk_pixbuf_save_to_buffer(pixbuf.get(), &buffer.outPtr(), &bufferSize,
             type.utf8().data(), &error, "quality", qualityString.utf8().data(), NULL);