Changeset 80553 in webkit

Timestamp:

Mar 8, 2011 1:54:26 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

2011-03-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add layoutTestController.setValueForUser() after r80412
​https://bugs.webkit.org/show_bug.cgi?id=55862

• platform/gtk/Skipped: Unskip test fast/forms/onchange-setvalueforuser.html that passes now.

2011-03-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add layoutTestController.setValueForUser() after r80412
​https://bugs.webkit.org/show_bug.cgi?id=55862

Add setValueForUser method to DumpRenderTreeSupportGTK.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setValueForUser):
• WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-03-08 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add layoutTestController.setValueForUser() after r80412
​https://bugs.webkit.org/show_bug.cgi?id=55862

• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setValueForUser): Implement setValueForUser()

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (modified) (2 diffs)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add layoutTestController.setValueForUser() after r80412
+        https://bugs.webkit.org/show_bug.cgi?id=55862
+
+        * platform/gtk/Skipped: Unskip test
+        fast/forms/onchange-setvalueforuser.html that passes now.
+
 2011-03-08  Noel Gordon  <noel.gordon@gmail.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -1309 +1309 @@
 fast/canvas/rgba-parsing.html
 
-# Missing layoutTestController.setValueForUser
-# https://bugs.webkit.org/show_bug.cgi?id=55862
-fast/forms/onchange-setvalueforuser.html
-
 # DataTransferItems is not yet implemented.
 editing/pasteboard/data-transfer-items.html

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add layoutTestController.setValueForUser() after r80412
+        https://bugs.webkit.org/show_bug.cgi?id=55862
+
+        Add setValueForUser method to DumpRenderTreeSupportGTK.
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::setValueForUser):
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+
 2011-03-07  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

@@ -35 +35 @@
 #include "GCController.h"
 #include "GraphicsContext.h"
+#include "InputElement.h"
 #include "JSDOMWindow.h"
 #include "JSDocument.h"
@@ -670 +671 @@
     core(webView)->settings()->setMinDOMTimerInterval(interval);
 }
+
+void DumpRenderTreeSupportGtk::setValueForUser(JSContextRef context, JSValueRef nodeObject, JSStringRef value)
+{
+    JSC::ExecState* exec = toJS(context);
+    Element* element = toElement(toJS(exec, nodeObject));
+    if (!element)
+        return;
+    InputElement* inputElement = toInputElement(element);
+    if (!inputElement)
+        return;
+
+    size_t bufferSize = JSStringGetMaximumUTF8CStringSize(value);
+    GOwnPtr<gchar> valueBuffer(static_cast<gchar*>(g_malloc(bufferSize)));
+    JSStringGetUTF8CString(value, valueBuffer.get(), bufferSize);
+    inputElement->setValueForUser(String::fromUTF8(valueBuffer.get()));
+}

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

@@ -86 +86 @@
     static AtkObject* getRootAccessibleElement(WebKitWebFrame*);
     static void layoutFrame(WebKitWebFrame*);
+    static void setValueForUser(JSContextRef, JSValueRef, JSStringRef);
 
     // WebKitWebView

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Add layoutTestController.setValueForUser() after r80412
+        https://bugs.webkit.org/show_bug.cgi?id=55862
+
+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+        (LayoutTestController::setValueForUser): Implement setValueForUser()
+
 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

@@ -333 +333 @@
 }
 
-void LayoutTestController::setValueForUser(JSContextRef context, JSValueRef element, JSStringRef value)
-{
-    // FIXME: implement
+void LayoutTestController::setValueForUser(JSContextRef context, JSValueRef nodeObject, JSStringRef value)
+{
+    DumpRenderTreeSupportGtk::setValueForUser(context, nodeObject, value);
 }