Changeset 80603 in webkit

Timestamp:

Mar 8, 2011 4:18:46 PM (13 years ago)

Author:

jeffm@apple.com

Message:

2011-03-08 Jeff Miller <​jeffm@apple.com>

Reviewed by Oliver Hunt.

WebKit2: Redo is broken
​https://bugs.webkit.org/show_bug.cgi?id=55978

WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
For example, when we unapply(), we should register a Redo command, not an Undo command.

• UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command. (WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebEditCommandProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-03-08  Jeff Miller  <jeffm@apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        WebKit2: Redo is broken
+        https://bugs.webkit.org/show_bug.cgi?id=55978
+        
+        WebEditCommandProxy::unapply() and WebEditCommandProxy::reapply() were registering the wrong edit command when an undo or redo happens.
+        For example, when we unapply(), we should register a Redo command, not an Undo command.
+
+        * UIProcess/WebEditCommandProxy.cpp:
+        (WebKit::WebEditCommandProxy::unapply): Register a Redo command, not an Undo command.
+        (WebKit::WebEditCommandProxy::reapply): Register an Undo command, not a Redo command.
+
 2011-03-08  Brent Fulgham  <bfulgham@webkit.org>
 

trunk/Source/WebKit2/UIProcess/WebEditCommandProxy.cpp

@@ -55 +55 @@
 
     m_page->process()->send(Messages::WebPage::UnapplyEditCommand(m_commandID), m_page->pageID());
-    m_page->registerEditCommand(this, WebPageProxy::Undo);
+    m_page->registerEditCommand(this, WebPageProxy::Redo);
 }
 
@@ -64 +64 @@
 
     m_page->process()->send(Messages::WebPage::ReapplyEditCommand(m_commandID), m_page->pageID());
-    m_page->registerEditCommand(this, WebPageProxy::Redo);
+    m_page->registerEditCommand(this, WebPageProxy::Undo);
 }