Changeset 80622 in webkit

Timestamp:

Mar 8, 2011 10:23:37 PM (13 years ago)

Author:

xji@chromium.org

Message:

2011-03-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
​https://bugs.webkit.org/show_bug.cgi?id=55077.

• fast/dom/scroll-reveal-left-overflow.html: Added.
• fast/dom/scroll-reveal-top-overflow.html: Added.
• platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
• platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
• platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
• platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
• platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
• platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.

2011-03-08 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Hyatt.

Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
​https://bugs.webkit.org/show_bug.cgi?id=55077.

Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
is negative, should include the position value into overhang rectangle's
starting position.

Tests: fast/dom/scroll-reveal-left-overflow.html

fast/dom/scroll-reveal-top-overflow.html

• platform/ScrollView.cpp: (WebCore::ScrollView::calculateOverhangAreasForPainting):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/scroll-reveal-left-overflow.html (added)
• LayoutTests/fast/dom/scroll-reveal-top-overflow.html (added)
• LayoutTests/platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum (added)
• LayoutTests/platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png (added)
• LayoutTests/platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt (added)
• LayoutTests/platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum (added)
• LayoutTests/platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png (added)
• LayoutTests/platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/ScrollView.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-03-08  Xiaomei Ji  <xji@chromium.org>
+
+        Reviewed by David Hyatt.
+
+        Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
+        https://bugs.webkit.org/show_bug.cgi?id=55077.
+
+        * fast/dom/scroll-reveal-left-overflow.html: Added.
+        * fast/dom/scroll-reveal-top-overflow.html: Added.
+        * platform/mac/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
+        * platform/mac/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
+        * platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
+        * platform/mac/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
+        * platform/mac/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
+        * platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
+
 2011-03-08  Gavin Barraclough  <barraclough@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-08  Xiaomei Ji  <xji@chromium.org>
+
+        Reviewed by David Hyatt.
+
+        Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
+        https://bugs.webkit.org/show_bug.cgi?id=55077.
+
+        Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
+        is negative, should include the position value into overhang rectangle's 
+        starting position. 
+
+        Tests: fast/dom/scroll-reveal-left-overflow.html
+               fast/dom/scroll-reveal-top-overflow.html
+
+        * platform/ScrollView.cpp:
+        (WebCore::ScrollView::calculateOverhangAreasForPainting):
+
 2011-03-08  Daniel Bates  <dbates@rim.com>
 

trunk/Source/WebCore/platform/ScrollView.cpp

@@ -971 +971 @@
         horizontalOverhangRect = frameRect();
         horizontalOverhangRect.setHeight(-scrollY());
+        horizontalOverhangRect.setY(scrollY());
     } else if (scrollY() > contentsHeight() - visibleContentRect().height()) {
         int height = scrollY() - (contentsHeight() - visibleContentRect().height());
@@ -981 +982 @@
         verticalOverhangRect.setWidth(-scrollX());
         verticalOverhangRect.setHeight(frameRect().height() - horizontalOverhangRect.height());
-        verticalOverhangRect.setX(frameRect().x());
+        verticalOverhangRect.setX(frameRect().x() + scrollX());
         if (horizontalOverhangRect.y() == frameRect().y())
             verticalOverhangRect.setY(frameRect().y() + horizontalOverhangRect.height());