Changeset 80866 in webkit

Timestamp:

Mar 11, 2011 11:18:28 AM (13 years ago)

Author:

cmarrin@apple.com

Message:

2011-03-09 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52468

Added WIN32 to the ifdef controlling whether animations are applied in normal or
reverse order. On Mac, animations used to be applied in reverse, but
<rdar://problem/7095638> fixed this in the release after Snow Leopard.
But that patch has not be applied to the Safari Windows SDK yet. For now
I've made Windows use the reverse order logig. <rdar://problem/9112233> is
tracking the inclusion of the patch on Windows.

• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/GraphicsLayerCA.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-03-09  Chris Marrin  <cmarrin@apple.com>
+
+        Reviewed by Adam Roben.
+
+        REGRESSION (5.0.3-ToT): Scrolling text doesn&apos;t scroll in Star Wars intro animation
+        https://bugs.webkit.org/show_bug.cgi?id=52468
+
+        Added WIN32 to the ifdef controlling whether animations are applied in normal or
+        reverse order. On Mac, animations used to be applied in reverse, but 
+        <rdar://problem/7095638> fixed this in the release after Snow Leopard.
+        But that patch has not be applied to the Safari Windows SDK yet. For now
+        I've made Windows use the reverse order logig. <rdar://problem/9112233> is
+        tracking the inclusion of the patch on Windows.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
+
 2011-03-11  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -1602 +1602 @@
         RefPtr<PlatformCAAnimation> caAnimation;
 
-#if defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD)
+#if defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD) || defined(WIN)
         // CA applies animations in reverse order (<rdar://problem/7095638>) so we need the last one we add (per property)
         // to be non-additive.
+        // FIXME: This fix has not been added to QuartzCore on Windows yet (<rdar://problem/9112233>) so we expect the
+        // reversed animation behavior
         bool additive = animationIndex < (numAnimations - 1);
 #else