Changeset 82343 in webkit

Timestamp:

Mar 29, 2011 3:55:37 PM (13 years ago)

Author:

Martin Robinson

Message:

2011-03-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=57067

Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
update DRT and pixel results as hundreds of results will need to be updated.

• DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow by overriding the theme RC/CSS files.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-03-24  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
+        https://bugs.webkit.org/show_bug.cgi?id=57067
+
+        Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
+        will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
+        update DRT and pixel results as hundreds of results will need to be updated.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
+        by overriding the theme RC/CSS files.
+
 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
 

trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -3 +3 @@
  * Copyright (C) 2008 Alp Toker <alp@nuanti.com>
  * Copyright (C) 2009 Jan Alonzo <jmalonzo@gmail.com>
- * Copyright (C) 2010 Igalia S.L.
+ * Copyright (C) 2010, 2011 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -601 +601 @@
     webkit_set_web_database_directory_path(databaseDirectory);
     g_free(databaseDirectory);
+
+#if defined(GTK_API_VERSION_2)
+    gtk_rc_parse_string("style \"nix_scrollbar_spacing\"                    "
+                        "{                                                  "
+                        "    GtkScrolledWindow::scrollbar-spacing = 0       "
+                        "}                                                  "
+                        "class \"GtkWidget\" style \"nix_scrollbar_spacing\"");
+
+#else
+    GtkCssProvider* cssProvider = gtk_css_provider_new();
+    gtk_css_provider_load_from_data(cssProvider,
+                                    " * {                                       "
+                                    "   -GtkScrolledWindow-scrollbar-spacing: 0;"
+                                    "}                                          ",
+                                    -1, 0);
+    gtk_style_context_add_provider_for_screen(gdk_display_get_default_screen(gdk_display_get_default()),
+                                              GTK_STYLE_PROVIDER(cssProvider),
+                                              GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+    g_object_unref(cssProvider);
+#endif
 }