Changeset 82615 in webkit

Timestamp:

Mar 31, 2011 2:09:30 PM (13 years ago)

Author:

Adam Roben

Message:

Specify both FILE_MAP_READ and FILE_MAP_WRITE when creating a read-write SharedMemory object

When passed to ::MapViewOfFile, FILE_MAP_WRITE implies FILE_MAP_READ, but other file mapping
APIs don't work that way. This bug wasn't causing any problems in practice, but it would
have prevented us from creating a DIB that wraps a SharedMemory object (which I noticed
while working on another bug).

Fixes <​http://webkit.org/b/57576> File mappings used by read-write SharedMemory objects
aren't correctly marked as read-write after being sent over a CoreIPC::Connection

Reviewed by Brian Weinstein.

• Platform/win/SharedMemoryWin.cpp:

(WebKit::accessRights): Specify FILE_MAP_READ in addition to FILE_MAP_WRITE for read-write
SharedMemory.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/win/SharedMemoryWin.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-03-31  Adam Roben  <aroben@apple.com>
+
+        Specify both FILE_MAP_READ and FILE_MAP_WRITE when creating a read-write SharedMemory object
+
+        When passed to ::MapViewOfFile, FILE_MAP_WRITE implies FILE_MAP_READ, but other file mapping
+        APIs don't work that way. This bug wasn't causing any problems in practice, but it would
+        have prevented us from creating a DIB that wraps a SharedMemory object (which I noticed
+        while working on another bug).
+
+        Fixes <http://webkit.org/b/57576> File mappings used by read-write SharedMemory objects
+        aren't correctly marked as read-write after being sent over a CoreIPC::Connection
+
+        Reviewed by Brian Weinstein.
+
+        * Platform/win/SharedMemoryWin.cpp:
+        (WebKit::accessRights): Specify FILE_MAP_READ in addition to FILE_MAP_WRITE for read-write
+        SharedMemory.
+
 2011-03-31  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebKit2/Platform/win/SharedMemoryWin.cpp

@@ -137 +137 @@
         return FILE_MAP_READ;
     case SharedMemory::ReadWrite:
-        // FILE_MAP_WRITE implies read access, too.
-        return FILE_MAP_WRITE;
+        return FILE_MAP_READ | FILE_MAP_WRITE;
     }