Changeset 82795 in webkit
- Timestamp:
- Apr 3, 2011 4:22:58 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r82793 r82795 1 2011-04-03 Dan Bernstein <mitz@apple.com> 2 3 Reviewed by Maciej Stachowiak. 4 5 fast/images/extra-image-in-image-document.html crashes when run after embed-image.html 6 https://bugs.webkit.org/show_bug.cgi?id=57733 7 8 The crash happens because resetting the page scale as part of preparing the WebView for the 9 next test triggered layout, which in turn caused a plug-in to make a resource request, and 10 DumpRenderTreeÕs delegate to be dispatched. The delegate doesnÕt expect to be called between 11 tests, and it references the layout test controller, which is null. 12 13 * page/Frame.cpp: 14 (WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isnÕt changing. This 15 is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although 16 DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale. 17 I think there are currently no such tests, so I am not fixing DumpRenderTree. 18 1 19 2011-04-03 Eric Seidel <eric@webkit.org> 2 20 … … 3789 3807 (WebCore::propertyNameMatchesAttributeName): 3790 3808 3791 2011-03-29 Csaba Osztrogon ác <ossy@webkit.org>3809 2011-03-29 Csaba Osztrogonác <ossy@webkit.org> 3792 3810 3793 3811 Unreviewed rollout r82282, part of r82288, r82298. … … 5439 5457 * inspector/generate-inspector-idl: 5440 5458 5441 2011-03-28 Csaba Osztrogon ác <ossy@webkit.org>5459 2011-03-28 Csaba Osztrogonác <ossy@webkit.org> 5442 5460 5443 5461 Buildfix after r82125. … … 5867 5885 2011-03-28 Nancy Piedra <nancy.piedra@nokia.com> 5868 5886 5869 Reviewed by Csaba Osztrogon ác.5887 Reviewed by Csaba Osztrogonác. 5870 5888 5871 5889 This patch fixes linking errors on Qt Webkit Windows MinGW builds. … … 10538 10556 2011-03-21 Andreas Kling <kling@webkit.org> 10539 10557 10540 Reviewed by Tor Arne Vestb ø.10558 Reviewed by Tor Arne Vestbø. 10541 10559 10542 10560 [Qt] Add QNetworkReplyHandler::wasAborted() … … 12969 12987 (WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): 12970 12988 12971 2011-03-16 Csaba Osztrogon ác <ossy@webkit.org>12989 2011-03-16 Csaba Osztrogonác <ossy@webkit.org> 12972 12990 12973 12991 [Qt] Buildfix after r81230. … … 13172 13190 only the clones on the RenderCombineText will be mutated. 13173 13191 * rendering/RenderCombineText.cpp: 13174 (WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent ’s13192 (WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parentâs 13175 13193 style. 13176 13194 (WebCore::RenderCombineText::combineText): Start off with the original font; restore it if 13177 13195 the text cannot be combined. 13178 13196 * rendering/RenderCombineText.h: 13179 (WebCore::RenderCombineText::originalFont): Added. Returns the parent ’s font.13197 (WebCore::RenderCombineText::originalFont): Added. Returns the parentâs font. 13180 13198 13181 13199 2011-03-14 Pavel Podivilov <podivilov@chromium.org> … … 19884 19902 2011-03-08 Joe Wild <joseph.wild@nokia.com> 19885 19903 19886 Reviewed by Csaba Osztrogon ác.19904 Reviewed by Csaba Osztrogonác. 19887 19905 19888 19906 [Qt] Missing SVG variables … … 20974 20992 * WebCore.gypi: 20975 20993 20976 2011-03-07 Csaba Osztrogon ác <ossy@webkit.org>20994 2011-03-07 Csaba Osztrogonác <ossy@webkit.org> 20977 20995 20978 20996 Unreviewed buildfix after r80478. … … 23933 23951 * editing/EditingStyle.h: 23934 23952 23935 2011-03-03 Csaba Osztrogon ác <ossy@webkit.org>23953 2011-03-03 Csaba Osztrogonác <ossy@webkit.org> 23936 23954 23937 23955 Unreviewed trivial fix after r80169. … … 24628 24646 2011-03-02 Aravind Akella <aravind.akella@nokia.com> 24629 24647 24630 Reviewed by Csaba Osztrogon ác.24648 Reviewed by Csaba Osztrogonác. 24631 24649 24632 24650 [Qt][WK2] Memory exhausted when building qtwebkit2 on linux … … 26542 26560 2011-03-01 Andras Becsi <abecsi@webkit.org> 26543 26561 26544 Reviewed by Csaba Osztrogon ác.26562 Reviewed by Csaba Osztrogonác. 26545 26563 26546 26564 [Qt] Clean up the project files and move common options to WebKit.pri. … … 27007 27025 Reviewed by Darin Adler. 27008 27026 27009 [Mac] Make "Change back to …" contextual menu item work with new autocorrection.27027 [Mac] Make "Change back to â¦" contextual menu item work with new autocorrection. 27010 27028 https://bugs.webkit.org/show_bug.cgi?id=55396 27011 27029 <rdar://problem/8836093> … … 27974 27992 Reviewed by Eric Seidel. 27975 27993 27976 <input value="type=submit"> throws a warning ( “HTML parse error”)27994 <input value="type=submit"> throws a warning (âHTML parse errorâ) 27977 27995 https://bugs.webkit.org/show_bug.cgi?id=55120 27978 27996 … … 30938 30956 * page/EventHandler.cpp: 30939 30957 (WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber 30940 to -1. Since WebKit2 doesn �t support non-activating clicks yet (<http://webkit.org/b/55053>30941 <rdar://problem/9042197>) and doesn �t send event numbers, all events were considered to be30958 to -1. Since WebKit2 doesn�t support non-activating clicks yet (<http://webkit.org/b/55053> 30959 <rdar://problem/9042197>) and doesn�t send event numbers, all events were considered to be 30942 30960 window-activating events. This in turn prevented them from clearing the selection and resuming 30943 30961 caret blinking on mouse up. … … 31438 31456 2011-02-22 Chang Shu <cshu@webkit.org> 31439 31457 31440 Reviewed by Csaba Osztrogon ác.31458 Reviewed by Csaba Osztrogonác. 31441 31459 31442 31460 [Qt] editing/deleting/5408255.html fails … … 31507 31525 2011-02-22 Andras Becsi <abecsi@webkit.org> 31508 31526 31509 Reviewed by Csaba Osztrogon ác.31527 Reviewed by Csaba Osztrogonác. 31510 31528 31511 31529 [Qt] Redesign the build system … … 31632 31650 31633 31651 Reviewed by Laszlo Gombos. 31634 Rubber-stamped by Csaba Osztrogon ác.31652 Rubber-stamped by Csaba Osztrogonác. 31635 31653 31636 31654 [Qt] Redesign the build system … … 32569 32587 (WebCore::InspectorDOMAgent::create): 32570 32588 32571 2011-02-21 Csaba Osztrogon ác <ossy@webkit.org>32589 2011-02-21 Csaba Osztrogonác <ossy@webkit.org> 32572 32590 32573 32591 Reviewed by Andreas Kling. … … 33346 33364 2011-02-18 Yi Shen <yi.4.shen@nokia.com> 33347 33365 33348 Reviewed by Tor Arne Vestb ø.33366 Reviewed by Tor Arne Vestbø. 33349 33367 33350 33368 Always display the media controls when requiresFullscreenForVideoPlayback() is true … … 33985 34003 (WebCore::DateComponents::parseTime): 33986 34004 33987 2011-02-18 Csaba Osztrogon ác <ossy@webkit.org>34005 2011-02-18 Csaba Osztrogonác <ossy@webkit.org> 33988 34006 33989 34007 Rubber-stamped by Andreas Kling. … … 34180 34198 * page/FrameView.cpp: 34181 34199 (WebCore::FrameView::scrollXForFixedPosition): Moved from ScrollView here and changed to 34182 account for page scale: when the page is scaled, the “viewport”with respect to which fixed34183 objects are positioned is scaled as well. Since it ’s now bigger than the real viewport (that is,34200 account for page scale: when the page is scaled, the âviewportâ with respect to which fixed 34201 objects are positioned is scaled as well. Since itâs now bigger than the real viewport (that is, 34184 34202 the frame view), we move it around in proportion to the document scroll, so that when the document 34185 34203 is fully scrolled to the bottom-right, the bottom right of the scaled viewport is visible. … … 34837 34855 (WebCore::RenderSVGResourcePattern::createTileImage): 34838 34856 34839 2011-02-17 Csaba Osztrogon ác <ossy@webkit.org>34857 2011-02-17 Csaba Osztrogonác <ossy@webkit.org> 34840 34858 34841 34859 Unreviewed. -
trunk/Source/WebCore/page/Frame.cpp
r82533 r82795 998 998 return; 999 999 1000 m_pageScaleFactor = scale; 1001 1002 if (document->renderer()) 1003 document->renderer()->setNeedsLayout(true); 1004 1005 document->recalcStyle(Node::Force); 1000 if (scale != m_pageScaleFactor) { 1001 m_pageScaleFactor = scale; 1002 1003 if (document->renderer()) 1004 document->renderer()->setNeedsLayout(true); 1005 1006 document->recalcStyle(Node::Force); 1006 1007 1007 1008 #if USE(ACCELERATED_COMPOSITING) 1008 updateContentsScale(scale); 1009 #endif 1009 updateContentsScale(scale); 1010 #endif 1011 } 1010 1012 1011 1013 if (FrameView* view = this->view()) {
Note: See TracChangeset
for help on using the changeset viewer.