Changeset 82875 in webkit


Ignore:
Timestamp:
Apr 4, 2011 2:40:10 PM (13 years ago)
Author:
ggaren@apple.com
Message:

2011-04-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
https://bugs.webkit.org/show_bug.cgi?id=57790

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::updateWeakHandles): Updated for rename.
  • collector/handles/HandleHeap.h: Removed comment claiming that this function should only be called during teardown, because it's actually called after every GC pass.
  • runtime/Heap.cpp: (JSC::Heap::destroy): (JSC::Heap::markRoots): Updated for rename.
Location:
trunk/Source/JavaScriptCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r82874 r82875  
     12011-04-04  Geoffrey Garen  <ggaren@apple.com>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
     6        https://bugs.webkit.org/show_bug.cgi?id=57790
     7
     8        * collector/handles/HandleHeap.cpp:
     9        (JSC::HandleHeap::updateWeakHandles): Updated for rename.
     10
     11        * collector/handles/HandleHeap.h: Removed comment claiming that this
     12        function should only be called during teardown, because it's actually
     13        called after every GC pass.
     14
     15        * runtime/Heap.cpp:
     16        (JSC::Heap::destroy):
     17        (JSC::Heap::markRoots): Updated for rename.
     18
    1192011-04-04  Geoffrey Garen  <ggaren@apple.com>
    220
  • trunk/Source/JavaScriptCore/collector/handles/HandleHeap.cpp

    r82874 r82875  
    5656}
    5757
    58 void HandleHeap::updateAfterMark()
    59 {
    60     clearWeakPointers();
    61 }
    62 
    63 void HandleHeap::clearWeakPointers()
     58void HandleHeap::updateWeakHandles()
    6459{
    6560    Node* end = m_weakList.end();
  • trunk/Source/JavaScriptCore/collector/handles/HandleHeap.h

    r82874 r82875  
    5757
    5858    void markStrongHandles(HeapRootMarker&);
    59     void updateAfterMark();
    60    
    61     // Should only be called during teardown.
    62     void clearWeakPointers();
     59    void updateWeakHandles();
    6360
    6461    void writeBarrier(HandleSlot, const JSValue&);
  • trunk/Source/JavaScriptCore/runtime/Heap.cpp

    r82327 r82875  
    8383    m_markListSet = 0;
    8484    m_markedSpace.clearMarks();
    85     m_handleHeap.clearWeakPointers();
     85    m_handleHeap.updateWeakHandles();
    8686    m_markedSpace.destroy();
    8787
     
    250250    markStack.compact();
    251251   
    252     m_handleHeap.updateAfterMark();
     252    m_handleHeap.updateWeakHandles();
    253253
    254254    m_operationInProgress = NoOperation;
Note: See TracChangeset for help on using the changeset viewer.