Changeset 82981 in webkit

Timestamp:

Apr 5, 2011 2:20:31 PM (13 years ago)

Author:

vitalyr@chromium.org

Message:

2011-04-04 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Keep dirty primitive CSS values alive.
​https://bugs.webkit.org/show_bug.cgi?id=57810

• bindings/v8/V8GCController.cpp: (WebCore::GrouperVisitor::visitDOMWrapper):

2011-04-04 Vitaly Repeshko <​vitalyr@chromium.org>

Reviewed by Adam Barth.

[V8] Keep dirty primitive CSS values alive.
​https://bugs.webkit.org/show_bug.cgi?id=57810

• platform/chromium/test_expectations.txt: Mark fast/dom/StyleSheet/gc-inline-style-cssvalues.html as passing.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/V8GCController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-04  Vitaly Repeshko  <vitalyr@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [V8] Keep dirty primitive CSS values alive.
+        https://bugs.webkit.org/show_bug.cgi?id=57810
+
+        * platform/chromium/test_expectations.txt: Mark
+        fast/dom/StyleSheet/gc-inline-style-cssvalues.html as passing.
+
 2011-04-05  Brian Weinstein  <bweinstein@apple.com>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3121 +3121 @@
 BUGCR75632 LINUX : svg/W3C-SVG-1.1/text-text-03-b.svg = CRASH PASS
 
-// I (antonm) am working on proper fix for it.  Temporary suppressing text differences.
-BUGWK55399 : fast/dom/StyleSheet/gc-inline-style-cssvalues.html = TEXT
-
 // Test changed in Wk r80743, throws an exception rather than returning 'true'
 BUGCR75740 : fast/js/regexp-test-null-string.html = FAIL

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-04  Vitaly Repeshko  <vitalyr@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        [V8] Keep dirty primitive CSS values alive.
+        https://bugs.webkit.org/show_bug.cgi?id=57810
+
+        * bindings/v8/V8GCController.cpp:
+        (WebCore::GrouperVisitor::visitDOMWrapper):
+
 2011-04-05  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/bindings/v8/V8GCController.cpp

@@ -360 +360 @@
             m_grouper.append(GrouperItem(groupId, wrapper));
 
+            // Keep alive "dirty" primitive values (i.e. the ones that
+            // have user-added properties) by creating implicit
+            // references between the style declaration and the values
+            // in it.
+            if (cssStyleDeclaration->isMutableStyleDeclaration()) {
+                CSSMutableStyleDeclaration* cssMutableStyleDeclaration = static_cast<CSSMutableStyleDeclaration*>(cssStyleDeclaration);
+                Vector<v8::Persistent<v8::Value> > values;
+                values.reserveCapacity(cssMutableStyleDeclaration->length());
+                CSSMutableStyleDeclaration::const_iterator end = cssMutableStyleDeclaration->end();
+                for (CSSMutableStyleDeclaration::const_iterator it = cssMutableStyleDeclaration->begin(); it != end; ++it) {
+                    v8::Persistent<v8::Object> value = store->domObjectMap().get(it->value());
+                    if (!value.IsEmpty() && value->IsDirty())
+                        values.append(value);
+                }
+                if (!values.isEmpty())
+                    v8::V8::AddImplicitReferences(wrapper, values.data(), values.size());
+            }
+
         } else if (typeInfo->isSubclass(&V8CSSRuleList::info)) {
             CSSRuleList* cssRuleList = static_cast<CSSRuleList*>(object);