Changeset 82996 in webkit


Ignore:
Timestamp:
Apr 5, 2011 3:59:47 PM (13 years ago)
Author:
thakis@chromium.org
Message:

2011-04-05 Nico Weber <​thakis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Don't have 'using namespace' declarations in header files
​https://bugs.webkit.org/show_bug.cgi?id=57882

  • src/EventListenerWrapper.cpp:
  • src/EventListenerWrapper.h:
  • src/VideoFrameChromiumImpl.h:
  • src/WebDOMEventListener.cpp:
  • src/WebDOMEventListenerPrivate.cpp:
  • src/WebDOMEventListenerPrivate.h: (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
Location:
trunk/Source/WebKit/chromium
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/chromium/ChangeLog

    r82976 r82996  
     12011-04-05  Nico Weber  <thakis@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [chromium] Don't have 'using namespace' declarations in header files
     6        https://bugs.webkit.org/show_bug.cgi?id=57882
     7
     8        * src/EventListenerWrapper.cpp:
     9        * src/EventListenerWrapper.h:
     10        * src/VideoFrameChromiumImpl.h:
     11        * src/WebDOMEventListener.cpp:
     12        * src/WebDOMEventListenerPrivate.cpp:
     13        * src/WebDOMEventListenerPrivate.h:
     14        (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
     15
    1162011-04-05  Zelidrag Hornung  <zelidrag@chromium.org>
    217

  • trunk/Source/WebKit/chromium/src/EventListenerWrapper.cpp

    r70231 r82996  
    3838#include "WebDOMEventListener.h"
    3939
     40using namespace WebCore;
     41
    4042namespace WebKit {
    4143

  • trunk/Source/WebKit/chromium/src/EventListenerWrapper.h

    r65743 r82996  
    3838}
    3939
    40 using namespace WebCore;
    41 
    4240namespace WebKit {
    4341
    … …  
    4644// FIXME: Remove the DeprecatedEventListenerWrapper class below once Chromium
    4745// switched to using WebDOMEvent.
    48 class EventListenerWrapper : public EventListener {
     46class EventListenerWrapper : public WebCore::EventListener {
    4947public:
    5048    EventListenerWrapper(WebDOMEventListener*);
    5149    ~EventListenerWrapper();
    5250
    53     virtual bool operator==(const EventListener&);
    54     virtual void handleEvent(ScriptExecutionContext*, Event*);
     51    virtual bool operator==(const WebCore::EventListener&);
     52    virtual void handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*);
    5553
    5654    void webDOMEventListenerDeleted();

  • trunk/Source/WebKit/chromium/src/VideoFrameChromiumImpl.h

    r78787 r82996  
    3535#include "WebVideoFrame.h"
    3636
    37 using namespace WebCore;
    38 
    3937namespace WebKit {
    4038
    4139// A wrapper class for WebKit::WebVideoFrame. Objects can be created in WebKit
    4240// and used in WebCore because of the VideoFrameChromium interface.
    43 class VideoFrameChromiumImpl : public VideoFrameChromium {
     41class VideoFrameChromiumImpl : public WebCore::VideoFrameChromium {
    4442public:
    4543    // Converts a WebCore::VideoFrameChromium to a WebKit::WebVideoFrame.
    46     static WebVideoFrame* toWebVideoFrame(VideoFrameChromium*);
     44    static WebVideoFrame* toWebVideoFrame(WebCore::VideoFrameChromium*);
    4745
    4846    // Creates a VideoFrameChromiumImpl object to wrap the given WebVideoFrame.
    … …  
    6058    virtual const void* data(unsigned plane) const;
    6159    virtual unsigned texture(unsigned plane) const;
    62     virtual const IntSize requiredTextureSize(unsigned plane) const;
     60    virtual const WebCore::IntSize requiredTextureSize(unsigned plane) const;
    6361    virtual bool hasPaddingBytes(unsigned plane) const;
    6462

  • trunk/Source/WebKit/chromium/src/WebDOMEventListener.cpp

    r65633 r82996  
    3434#include "WebDOMEventListenerPrivate.h"
    3535
     36using namespace WebCore;
     37
    3638namespace WebKit {
    3739

  • trunk/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.cpp

    r65633 r82996  
    3434#include "EventListenerWrapper.h"
    3535#include "WebDOMEventListener.h"
     36
     37using namespace WebCore;
    3638
    3739namespace WebKit {

  • trunk/Source/WebKit/chromium/src/WebDOMEventListenerPrivate.h

    r65633 r82996  
    4040}
    4141
    42 using namespace WebCore;
    43 
    4442namespace WebKit {
    4543
    … …  
    5351
    5452    EventListenerWrapper* createEventListenerWrapper(
    55         const WebString& eventType, bool useCapture, Node* node);
     53        const WebString& eventType, bool useCapture, WebCore::Node*);
    5654
    5755    // Gets the ListenerEventWrapper for a specific node.
    5856    // Used by WebNode::removeDOMEventListener().
    5957    EventListenerWrapper* getEventListenerWrapper(
    60         const WebString& eventType, bool useCapture, Node* node);
     58        const WebString& eventType, bool useCapture, WebCore::Node*);
    6159
    6260    // Called by the WebDOMEventListener when it is about to be deleted.
    … …  
    6967        ListenerInfo(const WebString& eventType, bool useCapture,
    7068                     EventListenerWrapper* eventListenerWrapper,
    71                      Node* node)
     69                     WebCore::Node* node)
    7270            : eventType(eventType)
    7371            , useCapture(useCapture)
    … …  
    8078        bool useCapture;
    8179        EventListenerWrapper* eventListenerWrapper;
    82         Node* node;
     80        WebCore::Node* node;
    8381    };
    8482
Note: See TracChangeset for help on using the changeset viewer.