Changeset 83016 in webkit

Timestamp:

Apr 5, 2011 9:35:01 PM (13 years ago)

Author:

ap@apple.com

Message:

2011-04-05 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

Rename event dispatching functions after form event removal
​https://bugs.webkit.org/show_bug.cgi?id=57908

• dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer):
• dom/Node.cpp: (WebCore::Node::dispatchChangeEvent): (WebCore::Node::dispatchInputEvent): (WebCore::Node::defaultEventHandler):
• dom/Node.h:
• html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent): Renamed "events" to "event", since there is only one event to dispatch now.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/InputElement.cpp (modified) (1 diff)
• dom/Node.cpp (modified) (2 diffs)
• dom/Node.h (modified) (1 diff)
• html/HTMLFormControlElement.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-05  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Darin Adler.
+
+        Rename event dispatching functions after form event removal
+        https://bugs.webkit.org/show_bug.cgi?id=57908
+
+        * dom/InputElement.cpp:
+        (WebCore::InputElement::setValueFromRenderer):
+        * dom/Node.cpp:
+        (WebCore::Node::dispatchChangeEvent):
+        (WebCore::Node::dispatchInputEvent):
+        (WebCore::Node::defaultEventHandler):
+        * dom/Node.h:
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
+        (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
+        (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
+        Renamed "events" to "event", since there is only one event to dispatch now.
+
 2011-04-05  Anders Bakken  <agbakken@gmail.com>
 

trunk/Source/WebCore/dom/InputElement.cpp

@@ -132 +132 @@
     // Input event is fired by the Node::defaultEventHandler for editable controls.
     if (!inputElement->isTextField())
-        element->dispatchInputEvents();
+        element->dispatchInputEvent();
     notifyFormStateChanged(element);
 }

trunk/Source/WebCore/dom/Node.cpp

@@ -2675 +2675 @@
 }
 
-void Node::dispatchChangeEvents()
+void Node::dispatchChangeEvent()
 {
     dispatchEvent(Event::create(eventNames().changeEvent, true, false));
 }
 
-void Node::dispatchInputEvents()
+void Node::dispatchInputEvent()
 {
     dispatchEvent(Event::create(eventNames().inputEvent, true, false));
@@ -2742 +2742 @@
                 frame->eventHandler()->defaultWheelEventHandler(startNode, wheelEvent);
     } else if (event->type() == eventNames().webkitEditableContentChangedEvent) {
-        dispatchInputEvents();
+        dispatchInputEvent();
     }
 }

trunk/Source/WebCore/dom/Node.h

@@ -540 +540 @@
     virtual void dispatchFocusEvent();
     virtual void dispatchBlurEvent();
-    virtual void dispatchChangeEvents();
-    virtual void dispatchInputEvents();
+    virtual void dispatchChangeEvent();
+    virtual void dispatchInputEvent();
 
     // Perform the default action for an event.

trunk/Source/WebCore/html/HTMLFormControlElement.cpp

@@ -202 +202 @@
 void HTMLFormControlElement::dispatchFormControlChangeEvent()
 {
-    HTMLElement::dispatchChangeEvents();
+    HTMLElement::dispatchChangeEvent();
     setChangedSinceLastFormControlChangeEvent(false);
 }
@@ -209 +209 @@
 {
     setChangedSinceLastFormControlChangeEvent(true);
-    HTMLElement::dispatchInputEvents();
+    HTMLElement::dispatchInputEvent();
 }
 
@@ -639 +639 @@
 {
     if (m_textAsOfLastFormControlChangeEvent != value()) {
-        HTMLElement::dispatchChangeEvents();
+        HTMLElement::dispatchChangeEvent();
         setTextAsOfLastFormControlChangeEvent(value());
     }