Changeset 83120 in webkit

Timestamp:

Apr 6, 2011 4:27:46 PM (13 years ago)

Author:

tony@chromium.org

Message:

2011-04-06 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

teach run-webkit-tests to read checksums from png files
​https://bugs.webkit.org/show_bug.cgi?id=57993

• Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's no .checksum and look for the checksum in there.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/old-run-webkit-tests (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-06  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        teach run-webkit-tests to read checksums from png files
+        https://bugs.webkit.org/show_bug.cgi?id=57993
+
+        * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
+          no .checksum and look for the checksum in there.
+
 2011-04-06  David Dorwin  <ddorwin@chromium.org>
 

trunk/Tools/Scripts/old-run-webkit-tests

@@ -106 +106 @@
 sub printFailureMessageForTest($$);
 sub processIgnoreTests($$);
+sub readChecksumFromPng($);
 sub readFromDumpToolWithTimer(**);
 sub readSkippedFiles($);
@@ -741 +742 @@
             # Format expected hash into a suffix string that is appended to the path / URL passed to DRT
             $suffixExpectedHash = "'$expectedHash";
+        } elsif (my $expectedHash = readChecksumFromPng(File::Spec->catfile($expectedPixelDir, "$base-$expectedTag.png"))) {
+            $suffixExpectedHash = "'$expectedHash";
         }
     }
@@ -2455 +2458 @@
 }
 
+sub readChecksumFromPng($)
+{
+    my ($path) = @_;
+    my $data;
+    if (open(PNGFILE, $path) && read(PNGFILE, $data, 2048) && $data =~ /tEXtchecksum\0([a-fA-F0-9]{32})/) {
+        return $1;
+    }
+}
+
 my @testsFound;