Changeset 83158 in webkit
- Timestamp:
- Apr 7, 2011 2:56:36 AM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r83152 r83158 1 2011-04-07 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Maciej Stachowiak. 4 5 webkit-patch shouldn't state the whole working copy when calling check-webkit-style 6 https://bugs.webkit.org/show_bug.cgi?id=58022 7 8 Previously, we were ignoring the args variable! This patch fixes the 9 regression introduced in http://trac.webkit.org/changeset/82771. 10 11 * Scripts/webkitpy/tool/commands/download_unittest.py: 12 * Scripts/webkitpy/tool/mocktool.py: 13 * Scripts/webkitpy/tool/steps/checkstyle.py: 14 1 15 2011-04-07 Maciej Stachowiak <mjs@apple.com> 2 16 -
trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py
r82771 r83158 124 124 125 125 def test_check_style(self): 126 expected_stderr = "Processing 1 patch from 1 bug.\nUpdating working directory\nProcessing patch 197 from bug 42.\n" 127 self.assert_execute_outputs(CheckStyle(), [197], options=self._default_options(), expected_stderr=expected_stderr) 126 expected_stderr = """Processing 1 patch from 1 bug. 127 Updating working directory 128 MOCK run_and_throw_if_fail: ['mock-update-webkit'] 129 Processing patch 197 from bug 42. 130 MOCK run_and_throw_if_fail: ['mock-check-webkit-style', '--git-commit', 'MOCK git commit', '--diff-files', 'MockFile1'] 131 """ 132 self.assert_execute_outputs(CheckStyle(), [197], options=self._default_options(), expected_stderr=expected_stderr, tool=MockTool(log_executive=True)) 128 133 129 134 def test_build_attachment(self): -
trunk/Tools/Scripts/webkitpy/tool/mocktool.py
r82688 r83158 694 694 return "/mock/results.html" 695 695 696 def check_webkit_style_command(self): 697 return ["mock-check-webkit-style"] 698 699 def update_webkit_command(self): 700 return ["mock-update-webkit"] 701 702 696 703 class MockTestPort1(object): 697 704 -
trunk/Tools/Scripts/webkitpy/tool/steps/checkstyle.py
r82771 r83158 57 57 58 58 try: 59 self._tool.executive.run_and_throw_if_fail(self._tool.port().check_webkit_style_command() )59 self._tool.executive.run_and_throw_if_fail(self._tool.port().check_webkit_style_command() + args) 60 60 except ScriptError, e: 61 61 if self._options.non_interactive:
Note: See TracChangeset
for help on using the changeset viewer.