Changeset 83237 in webkit


Ignore:
Timestamp:
Apr 7, 2011 6:18:59 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-07 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Adam Barth.

[Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
https://bugs.webkit.org/show_bug.cgi?id=57911
http://code.google.com/p/chromium/issues/detail?id=78073

Manual test added: manual-tests/autofill-popup-location.html

Originally only height is checked so that it introduces the bug.
So I changed it to check both width and height as size.

  • manual-tests/autofill-popup-location.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
Location:
trunk/Source/WebCore
Files:
1 added
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r83235 r83237  
     12011-04-07  Naoki Takano  <takano.naoki@gmail.com>
     2
     3        Reviewed by Adam Barth.
     4
     5        [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
     6        https://bugs.webkit.org/show_bug.cgi?id=57911
     7        http://code.google.com/p/chromium/issues/detail?id=78073
     8
     9        Manual test added: manual-tests/autofill-popup-location.html
     10
     11        Originally only height is checked so that it introduces the bug.
     12        So I changed it to check both width and height as size.
     13
     14        * manual-tests/autofill-popup-location.html: Added.
     15        * platform/chromium/PopupMenuChromium.cpp:
     16        (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
     17
    1182011-04-07  Adam Barth  <abarth@webkit.org>
    219
  • trunk/Source/WebCore/platform/chromium/PopupMenuChromium.cpp

    r80448 r83237  
    572572
    573573    listBox()->updateFromElement();
    574     // Store the original height to check if we need to request the location.
    575     int originalHeight = height();
     574    // Store the original size to check if we need to request the location.
     575    IntSize originalSize = size();
    576576    IntRect widgetRect = layoutAndCalculateWidgetRect(targetControlRect.height(), location);
    577     if (originalHeight != widgetRect.height())
     577    if (originalSize != widgetRect.size())
    578578        setFrameRect(widgetRect);
    579579
Note: See TracChangeset for help on using the changeset viewer.