Changeset 83270 in webkit


Ignore:
Timestamp:
Apr 8, 2011 2:04:42 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-08 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Make WK2 layoutTestController.shadowRoot return undefined, not
null, when its argument is not an element.
https://bugs.webkit.org/show_bug.cgi?id=58121

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shadowRoot):
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r83250 r83270  
     12011-04-08  Dominic Cooney  <dominicc@google.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Make WK2 layoutTestController.shadowRoot return undefined, not
     6        null, when its argument is not an element.
     7        https://bugs.webkit.org/show_bug.cgi?id=58121
     8
     9        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
     10        (WTR::LayoutTestController::shadowRoot):
     11
    1122011-04-07  Dirk Pranke  <dpranke@chromium.org>
    213
  • trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp

    r83195 r83270  
    361361
    362362    if (!element || !JSValueIsObject(context, element))
    363         return JSValueMakeNull(context);
     363        return JSValueMakeUndefined(context);
    364364
    365365    WKRetainPtr<WKBundleNodeHandleRef> domElement = adoptWK(WKBundleNodeHandleCreate(context, const_cast<JSObjectRef>(element)));
    366366    if (!domElement)
    367         return JSValueMakeNull(context);
     367        return JSValueMakeUndefined(context);
    368368
    369369    WKRetainPtr<WKBundleNodeHandleRef> shadowRootDOMElement = adoptWK(WKBundleNodeHandleCopyElementShadowRoot(domElement.get()));
Note: See TracChangeset for help on using the changeset viewer.