Changeset 83271 in webkit

Timestamp:

Apr 8, 2011 2:15:17 AM (13 years ago)

Author:

mario@webkit.org

Message:

2011-04-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=58039

Implemented missing functions in GTK's DRT.

• WebCoreSupport/DumpRenderTreeSupportGtk.h:
• WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (modifyAccessibilityValue): Helper function to increment or decrement the current value for an object through the AccessibilityObject's API. (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function, to be used from GTK's DRT. (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.

2011-04-08 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=58039

Implement missing functions in GTK's DRT.

• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::increment): Implemented. (AccessibilityUIElement::decrement): Implemented.

Location:

trunk

Files:

• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp (modified) (2 diffs)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
+        https://bugs.webkit.org/show_bug.cgi?id=58039
+
+        Implemented missing functions in GTK's DRT.
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (modifyAccessibilityValue): Helper function to increment or decrement
+        the current value for an object through the AccessibilityObject's API.
+        (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
+        to be used from GTK's DRT.
+        (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
+
 2011-04-06  Gustavo Noronha Silva  <gns@gnome.org>
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

@@ -680 +680 @@
 }
 
+static void modifyAccessibilityValue(AtkObject* axObject, bool increment)
+{
+    if (!axObject || !WEBKIT_IS_ACCESSIBLE(axObject))
+        return;
+
+    AccessibilityObject* coreObject = webkit_accessible_get_accessibility_object(WEBKIT_ACCESSIBLE(axObject));
+    if (!coreObject)
+        return;
+
+    if (increment)
+        coreObject->increment();
+    else
+        coreObject->decrement();
+}
+
+void DumpRenderTreeSupportGtk::incrementAccessibilityValue(AtkObject* axObject)
+{
+    modifyAccessibilityValue(axObject, true);
+}
+
+void DumpRenderTreeSupportGtk::decrementAccessibilityValue(AtkObject* axObject)
+{
+    modifyAccessibilityValue(axObject, false);
+}
+
 void DumpRenderTreeSupportGtk::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled)
 {

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

@@ -101 +101 @@
     static void setMinimumTimerInterval(WebKitWebView*, double);
 
+    // Accessibility
+    static void incrementAccessibilityValue(AtkObject*);
+    static void decrementAccessibilityValue(AtkObject*);
+
     // GC
     static void gcCollectJavascriptObjects();

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
+        https://bugs.webkit.org/show_bug.cgi?id=58039
+
+        Implement missing functions in GTK's DRT.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (AccessibilityUIElement::increment): Implemented.
+        (AccessibilityUIElement::decrement): Implemented.
+
 2011-04-08  Dominic Cooney  <dominicc@google.com>
 

trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

@@ -27 +27 @@
 #include "config.h"
 #include "AccessibilityUIElement.h"
+
 #include "GOwnPtr.h"
 #include "GRefPtr.h"
-
+#include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
 #include <JavaScriptCore/JSStringRef.h>
-#include <wtf/Assertions.h>
-
 #include <atk/atk.h>
 #include <gtk/gtk.h>
-
+#include <wtf/Assertions.h>
 
 AccessibilityUIElement::AccessibilityUIElement(PlatformUIElement element)
@@ -573 +572 @@
 void AccessibilityUIElement::increment()
 {
-    // FIXME: implement
+    if (!m_element)
+        return;
+
+    ASSERT(ATK_IS_OBJECT(m_element));
+    DumpRenderTreeSupportGtk::incrementAccessibilityValue(ATK_OBJECT(m_element));
 }
 
 void AccessibilityUIElement::decrement()
 {
-    // FIXME: implement
+    if (!m_element)
+        return;
+
+    ASSERT(ATK_IS_OBJECT(m_element));
+    DumpRenderTreeSupportGtk::decrementAccessibilityValue(ATK_OBJECT(m_element));
 }