Changeset 83306 in webkit

Timestamp:

Apr 8, 2011 9:59:54 AM (13 years ago)

Author:

andersca@apple.com

Message:

2011-04-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Clicks not recognized on ​http://www.nibblestutorials.net/ which uses Silverlight
​https://bugs.webkit.org/show_bug.cgi?id=58108
<rdar://problem/9167611>

Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
event has been handled. In this case it lead to a very subtle bug where the plug-in element would
lose focus right after a mouse down even had been sent.

• WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleMouseEvent):

Location:

trunk/Source

Files:

• WebCore/page/EventHandler.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm (modified) (2 diffs)

trunk/Source/WebCore/page/EventHandler.cpp

@@ -2176 +2176 @@
     }
 
+    printf("node: %s\n", targetNode(mev)->nodeName().utf8().data());
     swallowEvent = dispatchMouseEvent(eventNames().contextmenuEvent, targetNode(mev), true, 0, event, false);
     

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-07  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        Clicks not recognized on http://www.nibblestutorials.net/ which uses Silverlight
+        https://bugs.webkit.org/show_bug.cgi?id=58108
+        <rdar://problem/9167611>
+
+        Change platformHandleMouseEvent to return true, which means that the plug-in has handled the
+        event. Some plug-ins (like Silverlight) will return false from NPP_HandleEvent even though the
+        event has been handled. In this case it lead to a very subtle bug where the plug-in element would
+        lose focus right after a mouse down even had been sent.
+
+        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
+        (WebKit::NetscapePlugin::platformHandleMouseEvent):
+
 2011-04-07  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm

@@ -509 +509 @@
             RefPtr<NetscapePlugin> protect(this);
 
-            bool returnValue = NPP_HandleEvent(&event);
+            NPP_HandleEvent(&event);
 
             m_currentMouseEvent = previousMouseEvent;
 
-            return returnValue;
+            // Some plug-ins return false even if the mouse event has been handled.
+            // This leads to bugs such as <rdar://problem/9167611>. Work around this
+            // by always returning true.
+            return true;
         }
 
@@ -541 +544 @@
             event.where.v = mouseEvent.globalPosition().y();
 
-            return NPP_HandleEvent(&event);
+            NPP_HandleEvent(&event);
+
+            // Some plug-ins return false even if the mouse event has been handled.
+            // This leads to bugs such as <rdar://problem/9167611>. Work around this
+            // by always returning true.
+            return true;
         }
 #endif