Changeset 83316 in webkit

Timestamp:

Apr 8, 2011, 10:58:45 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-08 Misha Tyutyunik <​michael.tyutyunik@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Plugin is not scrolled together with page content or jumping
when content is rendered using cache (backing store).
​https://bugs.webkit.org/show_bug.cgi?id=56130

This is a Symbian portion of the fix. For Linux it looks like
it's enough to call set geometry which should be addressed in
​https://bugs.webkit.org/show_bug.cgi?id=57179

No new tests required. This can be tested with manual tests from
WebCore/manual-tests/qt and WebCore/manual-tests/plugins

• plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/symbian/PluginViewSymbian.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-08  Misha Tyutyunik  <michael.tyutyunik@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Plugin is not scrolled together with page content or jumping 
+        when content is rendered using cache (backing store).
+        https://bugs.webkit.org/show_bug.cgi?id=56130
+        
+        This is a Symbian portion of the fix. For Linux it looks like
+        it's enough to call set geometry which should be addressed in
+        https://bugs.webkit.org/show_bug.cgi?id=57179
+
+        No new tests required. This can be tested with manual tests from 
+        WebCore/manual-tests/qt and WebCore/manual-tests/plugins
+
+        * plugins/symbian/PluginViewSymbian.cpp:
+        (WebCore::PluginView::updatePluginWidget):
+
 2011-04-08  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/plugins/symbian/PluginViewSymbian.cpp

@@ -103 +103 @@
         return;
 
-    // in order to move/resize the plugin window at the same time as the rest of frame
-    // during e.g. scrolling, we set the mask and geometry in the paint() function, but
-    // as paint() isn't called when the plugin window is outside the frame which can
-    // be caused by a scroll, we need to move/resize immediately.
-    if (!m_windowRect.intersects(frameView->frameRect()))
-        setNPWindowIfNeeded();
+    setNPWindowIfNeeded();
 }