Changeset 83360 in webkit

Timestamp:

Apr 8, 2011 5:00:51 PM (13 years ago)

Author:

morrita@google.com

Message:

2011-04-08 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Negative spread should not make a sharp corner rounded
​https://bugs.webkit.org/show_bug.cgi?id=58162

Updated the result. This new result matches other browsers behavior.

• platform/mac/fast/box-shadow/inset-expected.checksum:
• platform/mac/fast/box-shadow/inset-expected.png:

2011-04-08 MORITA Hajime <​morrita@google.com>

Reviewed by Simon Fraser.

Negative spread should not make a sharp corner rounded
​https://bugs.webkit.org/show_bug.cgi?id=58162

Handled inset shadow path for rounded and non-rounded rect
differently as normal shadow path is doing.

• rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/fast/box-shadow/inset-expected.checksum (modified) (1 diff)
• LayoutTests/platform/mac/fast/box-shadow/inset-expected.png (modified) (previous)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBoxModelObject.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-08  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Simon Fraser.
+
+        Negative spread should not make a sharp corner rounded
+        https://bugs.webkit.org/show_bug.cgi?id=58162
+
+        Updated the result. This new result matches other browsers behavior.
+
+        * platform/mac/fast/box-shadow/inset-expected.checksum:
+        * platform/mac/fast/box-shadow/inset-expected.png:
+
 2011-04-08  Erik Arvidsson  <arv@chromium.org>
 

trunk/LayoutTests/platform/mac/fast/box-shadow/inset-expected.checksum

@@ -1 @@
-3635a2bcbd44aad76f5bc8d14d2a79fb
+4f3d4678f87ed88c7f1951794b34062c

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-08  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Simon Fraser.
+
+        Negative spread should not make a sharp corner rounded
+        https://bugs.webkit.org/show_bug.cgi?id=58162
+
+        Handled inset shadow path for rounded and non-rounded rect
+        differently as normal shadow path is doing.
+        
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::paintBoxShadow):
+
 2011-04-07  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -1739 +1739 @@
 
             IntRect outerRect = areaCastingShadowInHole(border.rect(), shadowBlur, shadowSpread, shadowOffset);
+            RoundedIntRect roundedHole(holeRect, border.radii());
+
             context->save();
 
-            Path path;
             if (hasBorderRadius) {
                 Path path;
                 path.addRoundedRect(border.rect(), border.radii().topLeft(), border.radii().topRight(), border.radii().bottomLeft(), border.radii().bottomRight());
                 context->clip(path);
+                roundedHole.shrinkRadii(shadowSpread);
             } else
                 context->clip(border.rect());
@@ -1758 +1760 @@
                 context->setShadow(shadowOffset, shadowBlur, shadowColor, s->colorSpace());
 
-            RoundedIntRect roundedHole(holeRect, border.radii());
-            roundedHole.shrinkRadii(shadowSpread);
             context->fillRectWithRoundedHole(outerRect, roundedHole, fillColor, s->colorSpace());