Changeset 83411 in webkit


Ignore:
Timestamp:
Apr 10, 2011 6:45:29 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-10 Daniel Bates <​dbates@rim.com>

Reviewed by Eric Seidel.

Add layout test to ensure that window.name returns {"_blank", "_parent", "_self", "_top"}
for a frame of the same name
​https://bugs.webkit.org/show_bug.cgi?id=58189

Extracted common code from files LayoutTests/fast/frames/resources/frame-element-name-{left, right}.html
into LayoutTests/fast/frames/resources/frame-element-name.html so that we can use this logic
to test frames with arbitrary names.

  • fast/frames/frame-element-name-expected.txt:
  • fast/frames/frame-element-name.html: Modified to use resources/frame-element-name.html; Added test cases for "_blank", "_parent", "_self", and "_top".
  • fast/frames/resources/frame-element-name-left.html: Removed; Instead, pass expectedName to resources/frame-element-name.html
  • fast/frames/resources/frame-element-name-right.html: Ditto.
  • fast/frames/resources/frame-element-name.html: Added.
Location:
trunk/LayoutTests
Files:
1 added
2 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83405 r83411  
     12011-04-10  Daniel Bates  <dbates@rim.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Add layout test to ensure that window.name returns {"_blank", "_parent", "_self", "_top"}
     6        for a frame of the same name
     7        https://bugs.webkit.org/show_bug.cgi?id=58189
     8
     9        Extracted common code from files LayoutTests/fast/frames/resources/frame-element-name-{left, right}.html
     10        into LayoutTests/fast/frames/resources/frame-element-name.html so that we can use this logic
     11        to test frames with arbitrary names.
     12
     13        * fast/frames/frame-element-name-expected.txt:
     14        * fast/frames/frame-element-name.html: Modified to use resources/frame-element-name.html; Added
     15          test cases for "_blank", "_parent", "_self", and "_top".
     16        * fast/frames/resources/frame-element-name-left.html: Removed; Instead, pass expectedName to
     17          resources/frame-element-name.html
     18        * fast/frames/resources/frame-element-name-right.html: Ditto.
     19        * fast/frames/resources/frame-element-name.html: Added.
     20
    1212011-04-10  Dimitri Glazkov  <dglazkov@chromium.org>
    222

  • trunk/LayoutTests/fast/frames/frame-element-name-expected.txt

    r71219 r83411  
    1414PASS escape(window.name) is ""
    1515
     16
     17--------
     18Frame: '<!--framePath //<!--frame2-->-->'
     19--------
     20PASS escape(window.frameElement.name) is "_blank"
     21PASS escape(window.name) is "_blank"
     22
     23
     24--------
     25Frame: '_parent'
     26--------
     27PASS escape(window.frameElement.name) is "_parent"
     28PASS escape(window.name) is "_parent"
     29
     30
     31--------
     32Frame: '_self'
     33--------
     34PASS escape(window.frameElement.name) is "_self"
     35PASS escape(window.name) is "_self"
     36
     37
     38--------
     39Frame: '_top'
     40--------
     41PASS escape(window.frameElement.name) is "_top"
     42PASS escape(window.name) is "_top"
     43

  • trunk/LayoutTests/fast/frames/frame-element-name.html

    r70185 r83411  
    66</script>
    77</head>
    8  <frameset border="1" cols="500,*" style='border: solid 1px;'>
    9   <frame marginwidth="1" src="resources/frame-element-name-left.html" name='left'>
    10   <frame src="resources/frame-element-name-right.html">
     8 <frameset border="1" cols="150,150,150,150,150,*" style='border: solid 1px;'>
     9  <frame marginwidth="1" src="resources/frame-element-name.html?expectedName=left" name="left">
     10  <frame src="resources/frame-element-name.html?expectedName=">
     11  <frame src="resources/frame-element-name.html?expectedName=_blank" name="_blank">
     12  <frame src="resources/frame-element-name.html?expectedName=_parent" name="_parent">
     13  <frame src="resources/frame-element-name.html?expectedName=_self" name="_self">
     14  <frame src="resources/frame-element-name.html?expectedName=_top" name="_top">
    1115 </frameset>
    1216</html>
Note: See TracChangeset for help on using the changeset viewer.