Changeset 83437 in webkit

Timestamp:

Apr 11, 2011 6:37:54 AM (13 years ago)

Author:

alexis.menard@openbossa.org

Message:

2011-04-11 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Regression : r83051 Oxygen's lineedits are not rendered properly
​https://bugs.webkit.org/show_bug.cgi?id=58076

State_Sunken is more generic than pressed. It is used by items such as frames or
line edits because they are "sunken" frames (e.g. QLineEdit). It can be required
by some style like Oxygen. Therefore only in the mobile theme we check if the object
is pressed.

• platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintTextField):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/RenderThemeQt.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly
+        https://bugs.webkit.org/show_bug.cgi?id=58076
+
+        State_Sunken is more generic than pressed. It is used by items such as frames or
+        line edits because they are "sunken" frames (e.g. QLineEdit). It can be required
+        by some style like Oxygen. Therefore only in the mobile theme we check if the object
+        is pressed.
+
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::paintTextField):
+
 2011-04-11  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp

@@ -674 +674 @@
     panel.rect = r;
     panel.lineWidth = findFrameLineWidth(qStyle());
+#if USE(QT_MOBILE_THEME)
     if (isPressed(o))
         panel.state |= QStyle::State_Sunken;
+#else
+    panel.state |= QStyle::State_Sunken;
+#endif
     panel.features = QStyleOptionFrameV2::None;