Changeset 83466 in webkit
- Timestamp:
- Apr 11, 2011 11:57:35 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 1 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r83465 r83466 1 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 2 3 Reviewed by Xan Lopez. 4 5 [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT 6 https://bugs.webkit.org/show_bug.cgi?id=57854 7 8 Unskipped table-cell-spans.html and updated GTK expectations. 9 10 * platform/gtk/Skipped: Unskipped test. 11 * platform/gtk/accessibility/table-cell-spans-expected.txt: Added. 12 1 13 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 2 14 -
trunk/LayoutTests/platform/gtk/Skipped
r83465 r83466 356 356 accessibility/selection-states.html 357 357 accessibility/table-attributes.html 358 accessibility/table-cell-spans.html359 358 accessibility/table-detection.html 360 359 accessibility/table-one-cell.html -
trunk/Tools/ChangeLog
r83465 r83466 1 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 2 3 Reviewed by Xan Lopez. 4 5 [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT 6 https://bugs.webkit.org/show_bug.cgi?id=57854 7 8 Implement missing features in GTK's DRT. 9 10 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: 11 (indexRangeInTable): New helper function to get the range string 12 for the current cell inside the parent table, either from the 13 point of view of rows or columns. 14 (AccessibilityUIElement::rowIndexRange): Implemented by relying on 15 the new helper function indexRangeInTable(). 16 (AccessibilityUIElement::columnIndexRange): Ditto. 17 1 18 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com> 2 19 -
trunk/Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp
r83465 r83466 488 488 } 489 489 490 static JSStringRef indexRangeInTable(PlatformUIElement element, bool isRowRange) 491 { 492 GOwnPtr<gchar> rangeString(g_strdup("{0, 0}")); 493 494 if (!element) 495 return JSStringCreateWithUTF8CString(rangeString.get()); 496 497 ASSERT(ATK_IS_OBJECT(element)); 498 499 AtkObject* axTable = atk_object_get_parent(ATK_OBJECT(element)); 500 if (!axTable || !ATK_IS_TABLE(axTable)) 501 return JSStringCreateWithUTF8CString(rangeString.get()); 502 503 // Look for the cell in the table. 504 gint indexInParent = atk_object_get_index_in_parent(ATK_OBJECT(element)); 505 if (indexInParent == -1) 506 return JSStringCreateWithUTF8CString(rangeString.get()); 507 508 int row = -1; 509 int column = -1; 510 row = atk_table_get_row_at_index(ATK_TABLE(axTable), indexInParent); 511 column = atk_table_get_column_at_index(ATK_TABLE(axTable), indexInParent); 512 513 // Get the actual values, if row and columns are valid values. 514 if (row != -1 && column != -1) { 515 int base = 0; 516 int length = 0; 517 if (isRowRange) { 518 base = row; 519 length = atk_table_get_row_extent_at(ATK_TABLE(axTable), row, column); 520 } else { 521 base = column; 522 length = atk_table_get_column_extent_at(ATK_TABLE(axTable), row, column); 523 } 524 rangeString.set(g_strdup_printf("{%d, %d}", base, length)); 525 } 526 527 return JSStringCreateWithUTF8CString(rangeString.get()); 528 } 529 490 530 JSStringRef AccessibilityUIElement::rowIndexRange() 491 531 { 492 // FIXME: implement493 return JSStringCreateWithCharacters(0, 0);532 // Range in table for rows. 533 return indexRangeInTable(m_element, true); 494 534 } 495 535 496 536 JSStringRef AccessibilityUIElement::columnIndexRange() 497 537 { 498 // FIXME: implement499 return JSStringCreateWithCharacters(0, 0);538 // Range in table for columns. 539 return indexRangeInTable(m_element, false); 500 540 } 501 541
Note: See TracChangeset
for help on using the changeset viewer.