Changeset 83473 in webkit

Timestamp:

Apr 11, 2011 12:14:10 PM (13 years ago)

Author:

alexis.menard@openbossa.org

Message:

2011-04-11 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Sub-Frame content is not updated when scrolling in certain circumstances
​https://bugs.webkit.org/show_bug.cgi?id=50373

Make sure that we invalidate the backing store when using TILED_BACKING_STORE
and the page contains sub frames. This bug appears only when frame flattening is
disabled and scrollable subframes.

Original patch from Thomas Thrainer.

• WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::invalidateWindow):

Location:

trunk/Source/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/ChromeClientQt.cpp (modified) (1 diff)

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Sub-Frame content is not updated when scrolling in certain circumstances
+        https://bugs.webkit.org/show_bug.cgi?id=50373
+
+        Make sure that we invalidate the backing store when using TILED_BACKING_STORE
+        and the page contains sub frames. This bug appears only when frame flattening is
+        disabled and scrollable subframes.
+
+        Original patch from Thomas Thrainer.
+
+        * WebCoreSupport/ChromeClientQt.cpp:
+        (WebCore::ChromeClientQt::invalidateWindow):
+
 2011-04-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
 

trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

@@ -400 +400 @@
 }
 
-void ChromeClientQt::invalidateWindow(const IntRect&, bool)
-{
-    notImplemented();
+void ChromeClientQt::invalidateWindow(const IntRect& windowRect, bool)
+{
+#if ENABLE(TILED_BACKING_STORE)
+    if (platformPageClient()) {
+        WebCore::TiledBackingStore* backingStore = QWebFramePrivate::core(m_webPage->mainFrame())->tiledBackingStore();
+        if (!backingStore)
+            return;
+        backingStore->invalidate(windowRect);
+    }
+#else
+    Q_UNUSED(windowRect);
+#endif
 }