Changeset 83503 in webkit

Timestamp:

Apr 11, 2011 2:44:30 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-11 Varun Jain <​varunjain@chromium.org>

Reviewed by Darin Fisher.

Resolving FIXME to make new WebWidget method pure virtual since all downstream classes have implemented the method.
​https://bugs.webkit.org/show_bug.cgi?id=58245

• Source/WebKit/chromium/public/WebWidget.h:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/public/WebWidget.h (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2011-04-11  Varun Jain  <varunjain@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        Resolving FIXME to make new WebWidget method pure virtual since all downstream classes have implemented the method.
+        https://bugs.webkit.org/show_bug.cgi?id=58245
+
+        *  Source/WebKit/chromium/public/WebWidget.h:
+
 2011-04-11  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
 

trunk/Source/WebKit/chromium/public/WebWidget.h

@@ -130 +130 @@
     // Returns the start and end point for the current selection, aligned to the
     // bottom of the selected line.
-    // FIXME: make this pure virtual after all downstream classes have
-    // implemented it.
-    virtual bool selectionRange(WebPoint& start, WebPoint& end) const
-    {
-        return false;
-    }
+    virtual bool selectionRange(WebPoint& start, WebPoint& end) const = 0;
 
     // Changes the text direction of the selected input node.