Changeset 83521 in webkit

Timestamp:

Apr 11, 2011 3:31:15 PM (13 years ago)

Author:

mdelaney@apple.com

Message:

2011-04-11 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Dan Bernstein.

[CG] drawImage with a subimage bleeds pixel data at borders
​https://bugs.webkit.org/show_bug.cgi?id=58267

Test: fast/canvas/DrawImageSinglePixelStretch.html

• platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Any interpolation quality other than 'none' will graft out the subimage first now.

2011-04-11 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Dan Bernstein.

[CG] drawImage with a subimage bleeds pixel data at borders
​https://bugs.webkit.org/show_bug.cgi?id=58267

• fast/canvas/DrawImageSinglePixelStretch.html: Added test case.
• fast/canvas/resources/orangePixels.gif: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/DrawImageSinglePixelStretch-expected.txt (added)
• LayoutTests/fast/canvas/DrawImageSinglePixelStretch.html (added)
• LayoutTests/fast/canvas/resources/orangePixels.gif (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/cg/ImageCG.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-04-11  Matthew Delaney  <mdelaney@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        [CG] drawImage with a subimage bleeds pixel data at borders
+        https://bugs.webkit.org/show_bug.cgi?id=58267
+
+        * fast/canvas/DrawImageSinglePixelStretch.html: Added test case.
+        * fast/canvas/resources/orangePixels.gif: Added.
+
 2011-04-11  Chris Marrin  <cmarrin@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-11  Matthew Delaney  <mdelaney@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        [CG] drawImage with a subimage bleeds pixel data at borders
+        https://bugs.webkit.org/show_bug.cgi?id=58267
+
+        Test: fast/canvas/DrawImageSinglePixelStretch.html
+
+        * platform/graphics/cg/ImageCG.cpp:
+        (WebCore::BitmapImage::draw): Any interpolation quality other than 'none' will graft out the subimage first now.
+
 2011-04-11  Chris Marrin  <cmarrin@apple.com>
 

trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp

@@ -200 +200 @@
         // interpolation smoothes sharp edges, causing pixels from outside the source rect to bleed
         // into the destination rect. See <rdar://problem/6112909>.
-        shouldUseSubimage = (interpolationQuality == kCGInterpolationHigh || interpolationQuality == kCGInterpolationDefault) && (srcRect.size() != destRect.size() || !ctxt->getCTM().isIdentityOrTranslationOrFlipped());
+        shouldUseSubimage = (interpolationQuality != kCGInterpolationNone) && (srcRect.size() != destRect.size() || !ctxt->getCTM().isIdentityOrTranslationOrFlipped());
         float xScale = srcRect.width() / destRect.width();
         float yScale = srcRect.height() / destRect.height();