Changeset 83599 in webkit


Ignore:
Timestamp:
Apr 12, 2011 9:36:22 AM (13 years ago)
Author:
loislo@chromium.org
Message:

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
​https://bugs.webkit.org/show_bug.cgi?id=58335

It was the method for Inspector layout tests.
We can use RuntimeAgent.evaluate instead.

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.completeTest):

2011-04-12 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
​https://bugs.webkit.org/show_bug.cgi?id=58335

It was the method for Inspector layout tests.
We can use RuntimeAgent.evaluate instead.

  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone):
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r83595 r83599  
     12011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
     6        https://bugs.webkit.org/show_bug.cgi?id=58335
     7
     8        It was the method for Inspector layout tests.
     9        We can use RuntimeAgent.evaluate instead.
     10
     11        * http/tests/inspector/inspector-test.js:
     12        (initialize_InspectorTest.InspectorTest.completeTest):
     13
    1142011-04-12  Brady Eidson  <beidson@apple.com>
    215

  • trunk/LayoutTests/http/tests/inspector/inspector-test.js

    r83583 r83599  
    1515InspectorTest.completeTest = function()
    1616{
    17     InspectorAgent.didEvaluateForTestInFrontend(InspectorTest.completeTestCallId, "");
     17    RuntimeAgent.evaluate("didEvaluateForTestInFrontend(" + InspectorTest.completeTestCallId + ", \"\")", "test");
    1818}
    1919

  • trunk/Source/WebCore/ChangeLog

    r83598 r83599  
     12011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
     6        https://bugs.webkit.org/show_bug.cgi?id=58335
     7
     8        It was the method for Inspector layout tests.
     9        We can use RuntimeAgent.evaluate instead.
     10
     11        * inspector/Inspector.json:
     12        * inspector/InspectorAgent.cpp:
     13        * inspector/InspectorAgent.h:
     14        * inspector/InspectorController.cpp:
     15        (WebCore::InspectorController::connectFrontend):
     16        * inspector/front-end/TestController.js:
     17        (WebInspector.TestController.prototype.notifyDone):
     18
    1192011-04-12  Philippe Normand  <pnormand@igalia.com>
    220

  • trunk/Source/WebCore/inspector/Inspector.json

    r83576 r83599  
    44        "types": [],
    55        "commands": [
    6             {
    7                 "name": "didEvaluateForTestInFrontend",
    8                 "parameters": [
    9                     { "name": "testCallId", "type": "integer" },
    10                     { "name": "jsonResult", "type": "string" }
    11                 ]
    12             }
    136        ],
    147        "events": [

  • trunk/Source/WebCore/inspector/InspectorAgent.cpp

    r82845 r83599  
    394394}
    395395
    396 void InspectorAgent::didEvaluateForTestInFrontend(ErrorString*, long callId, const String& jsonResult)
    397 {
    398     ScriptState* scriptState = scriptStateFromPage(debuggerWorld(), m_inspectedPage);
    399     ScriptObject window;
    400     ScriptGlobalObject::get(scriptState, "window", window);
    401     ScriptFunctionCall function(window, "didEvaluateForTestInFrontend");
    402     function.appendArgument(callId);
    403     function.appendArgument(jsonResult);
    404     function.call();
    405 }
    406 
    407396void InspectorAgent::setInspectorExtensionAPI(const String& source)
    408397{

  • trunk/Source/WebCore/inspector/InspectorAgent.h

    r82845 r83599  
    171171    void getInspectorState(RefPtr<InspectorObject>* state);
    172172    void setMonitoringXHREnabled(bool enabled, bool* newState);
    173     // Following are used from InspectorBackend and internally.
    174     void didEvaluateForTestInFrontend(ErrorString*, long callId, const String& jsonResult);
    175173
    176174private:

  • trunk/Source/WebCore/inspector/InspectorController.cpp

    r82803 r83599  
    133133        m_inspectorAgent->debuggerAgent(),
    134134#endif
    135         m_inspectorAgent.get(),
    136135        m_inspectorAgent->resourceAgent(),
    137136        m_inspectorAgent->pageAgent(),

  • trunk/Source/WebCore/inspector/front-end/TestController.js

    r79322 r83599  
    3737    {
    3838        var message = typeof result === "undefined" ? "\"<undefined>\"" : JSON.stringify(result);
    39         InspectorAgent.didEvaluateForTestInFrontend(callId, message);
     39        RuntimeAgent.evaluate("didEvaluateForTestInFrontend(" + callId + ", " + message + ")", "test");
    4040    }
    4141}
Note: See TracChangeset for help on using the changeset viewer.