Changeset 83606 in webkit
- Timestamp:
- Apr 12, 2011 10:35:36 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r83605 r83606 1 2011-04-12 Mario Sanchez Prada <msanchez@igalia.com> 2 3 Reviewed by Chris Fleizach. 4 5 [GTK] Expose menu items and menus as children of a menu bar 6 https://bugs.webkit.org/show_bug.cgi?id=56659 7 8 New cross-platform test. Skipped in platforms with no results yet. 9 10 * accessibility/aria-menubar-menuitems.html: Added. 11 * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Added. 12 * platform/mac/Skipped: Skipped the new test. 13 * platform/win/Skipped: Ditto. 14 1 15 2011-04-12 Jessie Berlin <jberlin@apple.com> 2 16 -
trunk/LayoutTests/platform/mac/Skipped
r83292 r83606 69 69 # Accessibility tests without results 70 70 accessibility/document-attributes.html 71 accessibility/aria-menubar-menuitems.html 71 72 72 73 # Accessibility tests with missing AccessibilityController functionality. -
trunk/LayoutTests/platform/win/Skipped
r83532 r83606 509 509 accessibility/aria-link-supports-press.html 510 510 accessibility/aria-list-and-listitem.html 511 accessibility/aria-menubar-menuitems.html 511 512 accessibility/aria-presentational-role.html 512 513 accessibility/aria-readonly.html -
trunk/Source/WebCore/ChangeLog
r83601 r83606 1 2011-04-12 Mario Sanchez Prada <msanchez@igalia.com> 2 3 Reviewed by Chris Fleizach. 4 5 [GTK] Expose menu items and menus as children of a menu bar 6 https://bugs.webkit.org/show_bug.cgi?id=56659 7 8 Ensure menu items get exposed when they're children of menu bars. 9 10 * accessibility/AccessibilityRenderObject.cpp: 11 (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): 12 Consider menu bars as potential parent objects for menu items. 13 1 14 2011-04-12 Pavel Feldman <pfeldman@google.com> 2 15 -
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
r83493 r83606 2975 2975 if (role) 2976 2976 return role; 2977 2978 AccessibilityObject* parentObject = parentObjectUnignored(); 2979 if (!parentObject) 2980 return UnknownRole; 2981 2982 AccessibilityRole parentAriaRole = parentObject->ariaRoleAttribute(); 2983 2977 2984 // selects and listboxes both have options as child roles, but they map to different roles within WebCore 2978 2985 if (equalIgnoringCase(ariaRole, "option")) { 2979 if (parent ObjectUnignored()->ariaRoleAttribute()== MenuRole)2986 if (parentAriaRole == MenuRole) 2980 2987 return MenuItemRole; 2981 if (parent ObjectUnignored()->ariaRoleAttribute()== ListBoxRole)2988 if (parentAriaRole == ListBoxRole) 2982 2989 return ListBoxOptionRole; 2983 2990 } 2984 2991 // an aria "menuitem" may map to MenuButton or MenuItem depending on its parent 2985 2992 if (equalIgnoringCase(ariaRole, "menuitem")) { 2986 if (parent ObjectUnignored()->ariaRoleAttribute()== GroupRole)2993 if (parentAriaRole == GroupRole) 2987 2994 return MenuButtonRole; 2988 if (parent ObjectUnignored()->ariaRoleAttribute() == MenuRole)2995 if (parentAriaRole == MenuRole || parentAriaRole == MenuBarRole) 2989 2996 return MenuItemRole; 2990 2997 }
Note: See TracChangeset
for help on using the changeset viewer.