Changeset 83647 in webkit

Timestamp:

Apr 12, 2011 3:05:34 PM (13 years ago)

Author:

andersca@apple.com

Message:

2011-04-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Assertion in DrawingAreaImpl::resumePainting() (m_isPaintingSuspended) when clicking a link at twitter.com
​https://bugs.webkit.org/show_bug.cgi?id=58377
<rdar://problem/8976531>

Remove the assertion.

• WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/DrawingAreaImpl.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-12  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Assertion in DrawingAreaImpl::resumePainting() (m_isPaintingSuspended) when clicking a link at twitter.com
+        https://bugs.webkit.org/show_bug.cgi?id=58377
+        <rdar://problem/8976531>
+
+        Remove the assertion.
+
+        * WebProcess/WebPage/DrawingAreaImpl.cpp:
+        (WebKit::DrawingAreaImpl::resumePainting):
+
 2011-04-11  Stephanie Lewis  <slewis@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp

@@ -363 +363 @@
 void DrawingAreaImpl::resumePainting()
 {
-    ASSERT(m_isPaintingSuspended);
-
+    if (!m_isPaintingSuspended) {
+        // FIXME: We can get a call to resumePainting when painting is not suspended.
+        // This happens when sending a synchronous message to create a new page. See <rdar://problem/8976531>.
+        return;
+    }
+        
     m_isPaintingSuspended = false;