Changeset 83653 in webkit

Timestamp:

Apr 12, 2011 3:43:19 PM (13 years ago)

Author:

cmarrin@apple.com

Message:

2011-04-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Page tears and stutters in WebKit2 when page is > 2048 pixels wide
​https://bugs.webkit.org/show_bug.cgi?id=58330

Added API to GraphicsLayer to disable switching to tiled layers. This is
set in the nonCompositedContentLayer in WK2, causing that layer to never
switch to tiles and avoiding the asynchronous update of the content during
scroll.

• platform/graphics/ca/GraphicsLayerCA.cpp:

Implement setAllowTiledLayer() to simulate a SizeChanged action to
properly switch between tiled and untiled layer.

• platform/graphics/ca/GraphicsLayerCA.h:

2011-04-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Page tears and stutters in WebKit2 when page is > 2048 pixels wide
​https://bugs.webkit.org/show_bug.cgi?id=58330

Turn off tiling for nonCompositedContentLayer to avoid tearing when
scrolling very wide (> 2048) windows.

• WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::initialize):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (modified) (3 diffs)
• WebCore/platform/graphics/ca/GraphicsLayerCA.h (modified) (2 diffs)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-12  Chris Marrin  <cmarrin@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        Page tears and stutters in WebKit2 when page is > 2048 pixels wide
+        https://bugs.webkit.org/show_bug.cgi?id=58330
+
+        Added API to GraphicsLayer to disable switching to tiled layers. This is 
+        set in the nonCompositedContentLayer in WK2, causing that layer to never
+        switch to tiles and avoiding the asynchronous update of the content during
+        scroll.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+            Implement setAllowTiledLayer() to simulate a SizeChanged action to 
+            properly switch between tiled and untiled layer.
+        * platform/graphics/ca/GraphicsLayerCA.h:
+
 2011-04-12  Alok Priyadarshi  <alokp@chromium.org>
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -256 +256 @@
     , m_uncommittedChanges(NoChange)
     , m_contentsScale(1)
+    , m_allowTiledLayer(true)
 {
     m_layer = PlatformCALayer::create(PlatformCALayer::LayerTypeWebLayer, this);
@@ -491 +492 @@
     GraphicsLayer::setAcceleratesDrawing(acceleratesDrawing);
     noteLayerPropertyChanged(AcceleratesDrawingChanged);
+}
+
+void GraphicsLayerCA::setAllowTiledLayer(bool allowTiledLayer)
+{
+    if (allowTiledLayer == m_allowTiledLayer)
+        return;
+
+    m_allowTiledLayer = allowTiledLayer;
+    
+    // Handling this as a SizeChanged will cause use to switch in or out of tiled layer as needed
+    noteLayerPropertyChanged(SizeChanged);
 }
 
@@ -2006 +2018 @@
 bool GraphicsLayerCA::requiresTiledLayer(const FloatSize& size) const
 {
-    if (!m_drawsContent)
+    if (!m_drawsContent || !m_allowTiledLayer)
         return false;
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h

@@ -122 +122 @@
     virtual void syncCompositingState();
     virtual void syncCompositingStateForThisLayerOnly();
+
+    bool allowTiledLayer() const { return m_allowTiledLayer; }
+    virtual void setAllowTiledLayer(bool b);
 
 protected:
@@ -400 +403 @@
     float clampedContentsScaleForScale(float) const;
     float m_contentsScale;
+    
+    bool m_allowTiledLayer;
 };
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-12  Chris Marrin  <cmarrin@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        Page tears and stutters in WebKit2 when page is > 2048 pixels wide
+        https://bugs.webkit.org/show_bug.cgi?id=58330
+
+        Turn off tiling for nonCompositedContentLayer to avoid tearing when
+        scrolling very wide (> 2048) windows.
+
+        * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
+        (WebKit::LayerTreeHostCA::initialize):
+
 2011-04-12  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp

@@ -60 +60 @@
 
     m_nonCompositedContentLayer = GraphicsLayer::create(this);
+    static_cast<GraphicsLayerCA*>(m_nonCompositedContentLayer.get())->setAllowTiledLayer(false);
 #ifndef NDEBUG
     m_nonCompositedContentLayer->setName("LayerTreeHost non-composited content");