Changeset 83688 in webkit

Timestamp:

Apr 12, 2011, 7:27:44 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-12 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Alexey Proskuryakov.

The default backspace event handler should mark the event as handled if navigation succeeds.
​https://bugs.webkit.org/show_bug.cgi?id=58379

We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
where history is managed by an external browser like IE.

No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
It is non trivial to simulate this environment.

• page/EventHandler.cpp: (WebCore::EventHandler::defaultBackspaceEventHandler):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/EventHandler.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        The default backspace event handler should mark the event as handled if navigation succeeds.
+        https://bugs.webkit.org/show_bug.cgi?id=58379
+
+        We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
+        These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
+        where history is managed by an external browser like IE.
+
+        No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
+        It is non trivial to simulate this environment.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::defaultBackspaceEventHandler):
+
 2011-04-12  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -2890 +2890 @@
         return;
 
+    bool handledEvent = false;
+
     if (event->shiftKey())
-        page->goForward();
+        handledEvent = page->goForward();
     else
-        page->goBack();
-
-    event->setDefaultHandled();
+        handledEvent = page->goBack();
+
+    if (handledEvent)
+        event->setDefaultHandled();
 }