Changeset 83849 in webkit
- Timestamp:
- Apr 14, 2011 6:35:54 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r83848 r83849 1 2011-04-14 Ilya Tikhonovsky <loislo@chromium.org> 2 3 Reviewed by Pavel Feldman. 4 5 Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector. 6 https://bugs.webkit.org/show_bug.cgi?id=57833 7 8 * inspector/Inspector.json: 9 * inspector/InspectorDatabaseAgent.cpp: 10 (WebCore::InspectorDatabaseAgent::didOpenDatabase): 11 (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): 12 (WebCore::InspectorDatabaseAgent::setFrontend): 13 (WebCore::InspectorDatabaseAgent::enable): 14 (WebCore::InspectorDatabaseAgent::disable): 15 (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): 16 (WebCore::InspectorDatabaseAgent::executeSQL): 17 * inspector/InspectorDatabaseAgent.h: 18 * inspector/front-end/inspector.js: 19 1 20 2011-04-14 Alexander Pavlov <apavlov@chromium.org> 2 21 -
trunk/Source/WebCore/inspector/Inspector.json
r83724 r83849 565 565 "types": [], 566 566 "commands": [ 567 { 568 "name": "enable", 569 "description": "Enables database tracking, database events will now be delivered to the client." 570 }, 571 { 572 "name": "disable", 573 "description": "Disables database tracking, prevents database events from being sent to the client." 574 }, 567 575 { 568 576 "name": "getDatabaseTableNames", -
trunk/Source/WebCore/inspector/InspectorDatabaseAgent.cpp
r83841 r83849 229 229 m_resources.set(resource->id(), resource); 230 230 // Resources are only bound while visible. 231 if (m_frontendProvider )231 if (m_frontendProvider && m_enabled) 232 232 resource->bind(m_frontendProvider->frontend()); 233 233 } … … 240 240 InspectorDatabaseAgent::InspectorDatabaseAgent(InstrumentingAgents* instrumentingAgents) 241 241 : m_instrumentingAgents(instrumentingAgents) 242 , m_enabled(false) 242 243 { 243 244 m_instrumentingAgents->setInspectorDatabaseAgent(this); … … 252 253 { 253 254 m_frontendProvider = FrontendProvider::create(frontend); 255 } 256 257 void InspectorDatabaseAgent::clearFrontend() 258 { 259 m_frontendProvider->clearFrontend(); 260 m_frontendProvider.clear(); 261 } 262 263 void InspectorDatabaseAgent::enable(ErrorString*) 264 { 265 if (m_enabled) 266 return; 267 m_enabled = true; 268 254 269 DatabaseResourcesMap::iterator databasesEnd = m_resources.end(); 255 270 for (DatabaseResourcesMap::iterator it = m_resources.begin(); it != databasesEnd; ++it) … … 257 272 } 258 273 259 void InspectorDatabaseAgent::clearFrontend() 260 { 261 m_frontendProvider->clearFrontend(); 262 m_frontendProvider.clear(); 263 } 264 265 void InspectorDatabaseAgent::getDatabaseTableNames(ErrorString*, int databaseId, RefPtr<InspectorArray>* names) 266 { 274 void InspectorDatabaseAgent::disable(ErrorString*) 275 { 276 if (!m_enabled) 277 return; 278 m_enabled = false; 279 } 280 281 void InspectorDatabaseAgent::getDatabaseTableNames(ErrorString* error, int databaseId, RefPtr<InspectorArray>* names) 282 { 283 if (!m_enabled) { 284 *error = "Database agent is not enabled"; 285 return; 286 } 287 267 288 Database* database = databaseForId(databaseId); 268 289 if (database) { … … 274 295 } 275 296 276 void InspectorDatabaseAgent::executeSQL(ErrorString*, int databaseId, const String& query, bool* success, int* transactionId) 277 { 297 void InspectorDatabaseAgent::executeSQL(ErrorString* error, int databaseId, const String& query, bool* success, int* transactionId) 298 { 299 if (!m_enabled) { 300 *error = "Database agent is not enabled"; 301 return; 302 } 303 278 304 Database* database = databaseForId(databaseId); 279 305 if (!database) { -
trunk/Source/WebCore/inspector/InspectorDatabaseAgent.h
r83841 r83849 60 60 61 61 // Called from the front-end. 62 void enable(ErrorString*); 63 void disable(ErrorString*); 62 64 void getDatabaseTableNames(ErrorString*, int databaseId, RefPtr<InspectorArray>* names); 63 65 void executeSQL(ErrorString*, int databaseId, const String& query, bool* success, int* transactionId); … … 77 79 DatabaseResourcesMap m_resources; 78 80 RefPtr<FrontendProvider> m_frontendProvider; 81 bool m_enabled; 79 82 }; 80 83 -
trunk/Source/WebCore/inspector/front-end/inspector.js
r83062 r83849 508 508 ConsoleAgent.setMonitoringXHREnabled(true); 509 509 ConsoleAgent.enable(this.console.setConsoleMessageExpiredCount.bind(this.console)); 510 511 DatabaseAgent.enable(); 510 512 511 513 WebInspector.showPanel(WebInspector.settings.lastActivePanel);
Note: See TracChangeset
for help on using the changeset viewer.