Changeset 84156 in webkit

Timestamp:

Apr 18, 2011 10:14:03 AM (13 years ago)

Author:

morrita@google.com

Message:

2011-04-15 MORITA Hajime <​morrita@google.com>

Reviewed by Adam Barth.

REGRESSION: <progress> doesn't animate if it doesn't have value
​https://bugs.webkit.org/show_bug.cgi?id=58693

The initial value of RenderProgress::m_position is accidentally same as
the indeterminate value, that makes update code on updateFromElement() skipped.
This change set unique invalid value for the initial value of m_position.

No new tests. Testing animated bar is not possible with DRT.

• html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::position):
• html/HTMLProgressElement.h:
• rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::isDeterminate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLProgressElement.cpp (modified) (2 diffs)
• html/HTMLProgressElement.h (modified) (1 diff)
• rendering/RenderProgress.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-15  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Adam Barth.
+
+        REGRESSION: <progress> doesn't animate if it doesn't have value
+        https://bugs.webkit.org/show_bug.cgi?id=58693
+
+        The initial value of RenderProgress::m_position is accidentally same as
+        the indeterminate value, that makes update code on updateFromElement() skipped.
+        This change set unique invalid value for the initial value of m_position.
+        
+        No new tests. Testing animated bar is not possible with DRT.
+
+        * html/HTMLProgressElement.cpp:
+        (WebCore::HTMLProgressElement::position):
+        * html/HTMLProgressElement.h:
+        * rendering/RenderProgress.cpp:
+        (WebCore::RenderProgress::RenderProgress):
+        (WebCore::RenderProgress::isDeterminate):
+
 2011-04-18  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/html/HTMLProgressElement.cpp

@@ -39 +39 @@
 
 using namespace HTMLNames;
+
+const double HTMLProgressElement::IndeterminatePosition = -1;
+const double HTMLProgressElement::InvalidPosition = -2;
 
 HTMLProgressElement::HTMLProgressElement(const QualifiedName& tagName, Document* document, HTMLFormElement* form)
@@ -124 +127 @@
 {
     if (!hasAttribute(valueAttr))
-        return -1;
+        return HTMLProgressElement::IndeterminatePosition;
     return value() / max();
 }

trunk/Source/WebCore/html/HTMLProgressElement.h

@@ -31 +31 @@
 class HTMLProgressElement : public HTMLFormControlElement {
 public:
+    static const double IndeterminatePosition;
+    static const double InvalidPosition;
+
     static PassRefPtr<HTMLProgressElement> create(const QualifiedName&, Document*, HTMLFormElement*);
 

trunk/Source/WebCore/rendering/RenderProgress.cpp

@@ -39 +39 @@
 RenderProgress::RenderProgress(HTMLProgressElement* element)
     : RenderBlock(element)
-    , m_position(-1)
+    , m_position(HTMLProgressElement::InvalidPosition)
     , m_animationStartTime(0)
     , m_animationRepeatInterval(0)
@@ -70 +70 @@
 bool RenderProgress::isDeterminate() const
 {
-    return 0 <= position();
+    return (HTMLProgressElement::IndeterminatePosition != position()
+            && HTMLProgressElement::InvalidPosition != position());
 }