Changeset 84253 in webkit

Timestamp:

Apr 19, 2011 7:35:33 AM (13 years ago)

Author:

andreas.kling@nokia.com

Message:

2011-04-19 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

WebKit2: Typo fix in WebPopupMenu::Type.
​https://bugs.webkit.org/show_bug.cgi?id=58891

Fixed a typo, Seperator -> Separator.
Also removed m_ prefix on an argument variable name.

• Shared/WebPopupItem.h:
• UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::populate):
• WebProcess/WebCoreSupport/WebPopupMenu.cpp: (WebKit::WebPopupMenu::populateItems):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPopupItem.h (modified) (2 diffs)
• UIProcess/mac/WebPopupMenuProxyMac.mm (modified) (1 diff)
• WebProcess/WebCoreSupport/WebPopupMenu.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-04-19  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        WebKit2: Typo fix in WebPopupMenu::Type.
+        https://bugs.webkit.org/show_bug.cgi?id=58891
+
+        Fixed a typo, Seperator -> Separator.
+        Also removed m_ prefix on an argument variable name.
+
+        * Shared/WebPopupItem.h:
+        * UIProcess/mac/WebPopupMenuProxyMac.mm:
+        (WebKit::WebPopupMenuProxyMac::populate):
+        * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
+        (WebKit::WebPopupMenu::populateItems):
+
 2011-04-19  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/Source/WebKit2/Shared/WebPopupItem.h

@@ -39 +39 @@
 struct WebPopupItem {
     enum Type {
-        Seperator,
+        Separator,
         Item
     };
@@ -45 +45 @@
     WebPopupItem();
     WebPopupItem(Type);
-    WebPopupItem(Type, const String& text, WebCore::TextDirection, bool hasTextDirectionOverride, const String& toolTip, const String& accessibilityText, bool isEnabled, bool m_isLabel);
+    WebPopupItem(Type, const String& text, WebCore::TextDirection, bool hasTextDirectionOverride, const String& toolTip, const String& accessibilityText, bool isEnabled, bool isLabel);
 
     void encode(CoreIPC::ArgumentEncoder*) const;

trunk/Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm

@@ -63 +63 @@
 
     for (int i = 0; i < size; i++) {
-        if (items[i].m_type == WebPopupItem::Seperator)
+        if (items[i].m_type == WebPopupItem::Separator)
             [[m_popup.get() menu] addItem:[NSMenuItem separatorItem]];
         else {

trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPopupMenu.cpp

@@ -82 +82 @@
     for (size_t i = 0; i < size; ++i) {
         if (m_popupClient->itemIsSeparator(i))
-            items.append(WebPopupItem(WebPopupItem::Seperator));
+            items.append(WebPopupItem(WebPopupItem::Separator));
         else {
             // FIXME: Add support for styling the font.