Changeset 84258 in webkit


Ignore:
Timestamp:
Apr 19, 2011 9:36:05 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

Chromium DevTools: Network panel timing test is flaky
https://bugs.webkit.org/show_bug.cgi?id=58699

Fixed network timing test flakiness.

  • src/js/Tests.js: (.TestSuite.prototype.testNetworkTiming.finishResource):
Location:
trunk/Source/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r84254 r84258  
     12011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Chromium DevTools: Network panel timing test is flaky
     6        https://bugs.webkit.org/show_bug.cgi?id=58699
     7
     8        Fixed network timing test flakiness.
     9
     10        * src/js/Tests.js:
     11        (.TestSuite.prototype.testNetworkTiming.finishResource):
     12
    1132011-04-19  Andrey Kosyakov  <caseq@chromium.org>
    214
  • trunk/Source/WebKit/chromium/src/js/Tests.js

    r83958 r84258  
    601601    function finishResource(resource, finishTime)
    602602    {
    603         test.assertTrue(resource.timing.receiveHeadersEnd - resource.timing.connectStart >= 100, "Time between connectStart and receiveHeadersEnd should be more than 100ms.");       
    604         test.assertTrue(resource.endTime - resource.responseReceivedTime >= 0.1, "Time between endTime and responseReceivedTime should be more than 100ms.");       
    605         test.assertTrue(resource.responseReceivedTime - resource.startTime >= 0.1, "Time between responseReceivedTime and startTime should be more than 100ms.");       
     603        test.assertTrue(resource.timing.receiveHeadersEnd - resource.timing.connectStart >= 100,
     604                        "Time between receiveHeadersEnd and connectStart should be >=100ms, but was " +
     605                        "receiveHeadersEnd=" + resource.timing.receiveHeadersEnd + ", connectStart=" + resource.timing.connectStart + ".");
     606        test.assertTrue(resource.endTime - resource.startTime >= 0.2,
     607                        "Time between endTime and startTime should be >=200ms, but was " +
     608                        "endtime=" + resource.endTime + ", startTime=" + resource.startTime + ".");
     609       
    606610        test.releaseControl();
    607611    }
Note: See TracChangeset for help on using the changeset viewer.