Changeset 84263 in webkit

Timestamp:

Apr 19, 2011 10:15:25 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-04-19 Igor Oliveira <​igor.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] X11: Text selection is causing oncopy event to be called
​https://bugs.webkit.org/show_bug.cgi?id=58656

Always when text is selected the oncopy event is fired, this behavior does
not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
is making multi part-copies (with rich text metadata), the multi-part
data can be obtained by data transfer items interface when supported by QtWebKit.
Also, copies to the clipboard of a selected image, is not supported by Chrome and
Firefox and was removed from QtWebKit.

• Api/qwebpage.cpp: (QWebPagePrivate::handleClipboard):

Location:

trunk

Files:

• LayoutTests/editing/pasteboard/text-selection-expected.txt (added)
• LayoutTests/editing/pasteboard/text-selection.html (added)
• Source/WebKit/qt/Api/qwebpage.cpp (modified) (1 diff)
• Source/WebKit/qt/ChangeLog (modified) (1 diff)

trunk/Source/WebKit/qt/Api/qwebpage.cpp

@@ -748 +748 @@
         if (button == Qt::LeftButton) {
             if (focusFrame && (focusFrame->editor()->canCopy() || focusFrame->editor()->canDHTMLCopy())) {
-                focusFrame->editor()->copy();
+                Pasteboard::generalPasteboard()->writeSelection(focusFrame->editor()->selectedRange().get(), focusFrame->editor()->canSmartCopyOrDelete(), focusFrame);
                 ev->setAccepted(true);
             }

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-04-19  Igor Oliveira  <igor.oliveira@openbossa.org>
+
+        Reviewed by Andreas Kling.
+
+        [Qt] X11: Text selection is causing oncopy event to be called
+        https://bugs.webkit.org/show_bug.cgi?id=58656
+
+        Always when text is selected the oncopy event is fired, this behavior does
+        not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
+        is making multi part-copies (with rich text metadata), the multi-part
+        data can be obtained by data transfer items interface when supported by QtWebKit.
+        Also, copies to the clipboard of a selected image, is not supported by Chrome and
+        Firefox and was removed from QtWebKit.
+
+
+        * Api/qwebpage.cpp:
+        (QWebPagePrivate::handleClipboard):
+
 2011-04-18  Csaba Osztrogonác  <ossy@webkit.org>