Changeset 84351 in webkit

Timestamp:

Apr 20, 2011 2:21:36 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2011-04-20 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: minor protocol cleanups (refined types).
​https://bugs.webkit.org/show_bug.cgi?id=58970

• inspector/InjectedScriptSource.js:
• inspector/Inspector.json:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InjectedScriptSource.js (modified) (1 diff)
• inspector/Inspector.json (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-20  Pavel Feldman  <pfeldman@google.com>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: minor protocol cleanups (refined types).
+        https://bugs.webkit.org/show_bug.cgi?id=58970
+
+        * inspector/InjectedScriptSource.js:
+        * inspector/Inspector.json:
+
 2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>
 

trunk/Source/WebCore/inspector/InjectedScriptSource.js

@@ -475 +475 @@
     this.id = "{\"ordinal\":" + ordinal + ",\"injectedScriptId\":" + injectedScriptId + "}";
     this.functionName = (callFrame.type === "function" ? callFrame.functionName : "");
-    this.location = { sourceID: callFrame.sourceID, lineNumber: callFrame.line, columnNumber: callFrame.column };
+    this.location = { sourceID: String(callFrame.sourceID), lineNumber: callFrame.line, columnNumber: callFrame.column };
     this.scopeChain = this._wrapScopeChain(callFrame);
 }

trunk/Source/WebCore/inspector/Inspector.json

@@ -134 +134 @@
                 "properties": [
                     { "name": "description", "type": "string", "description": "String representation of the object." },
-                    { "name": "hasChildren", "type": "integer", "optional": true, "description": "True when this object can be queried for children." },
+                    { "name": "hasChildren", "type": "boolean", "optional": true, "description": "True when this object can be queried for children." },
                     { "name": "objectId", "type": "string", "optional": true, "description": "Unique object identifier (for non-primitive values)." },
                     { "name": "type", "type": "string", "enum": ["object", "array", "function", "null", "node", "undefined", "string", "number", "boolean", "error", "regexp", "date"], "description": "Object type." }
@@ -146 +146 @@
                     { "name": "name", "type": "string", "description": "Property name." },
                     { "name": "value", "$ref": "RemoteObject", "description": "Property value." },
-                    { "name": "isGetter", "type": "string", "description": "True if this property is getter." }
+                    { "name": "isGetter", "type": "boolean", "optional": true, "description": "True if this property is getter." }
                 ]
             }
@@ -181 +181 @@
                 ],
                 "returns": [
-                    { "name": "result", "type": "array", "items": { "$ref": "RuntimeProperty"}, "description": "Object properties." }
+                    { "name": "result", "type": "array", "items": { "$ref": "RemoteProperty"}, "description": "Object properties." }
                 ],
                 "description": "Returns properties of a given object."