Changeset 84371 in webkit

Timestamp:

Apr 20, 2011 7:40:02 AM (13 years ago)

Author:

mihaip@chromium.org

Message:

2011-04-19 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

ScriptController.h is included in too many places
​https://bugs.webkit.org/show_bug.cgi?id=58963

Remove ScriptController.h #includes from a bunch of .cpp files where it
doesn't appear to be necessary.

• bindings/js/JSCustomPositionCallback.cpp:
• bindings/js/JSCustomPositionErrorCallback.cpp:
• bindings/js/JSCustomVoidCallback.cpp:
• bindings/js/JSCustomXPathNSResolver.cpp:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/js/JSDOMWindowShell.cpp:
• bindings/js/JSDocumentCustom.cpp:
• bindings/js/ScriptDebugServer.cpp:
• bindings/v8/NPV8Object.cpp:
• bindings/v8/ScriptCachedFrameData.cpp:
• bindings/v8/V8DOMWindowShell.cpp:
• bindings/v8/V8DOMWrapper.cpp:
• bindings/v8/V8IsolatedContext.cpp:
• bindings/v8/V8Proxy.cpp:
• bindings/v8/custom/V8LocationCustom.cpp:
• dom/Node.cpp:
• dom/ScriptElement.cpp:
• dom/XMLDocumentParser.cpp:
• dom/XMLDocumentParserQt.cpp:
• html/HTMLEmbedElement.cpp:
• html/HTMLObjectElement.cpp:
• html/HTMLPlugInElement.cpp:
• html/parser/HTMLConstructionSite.cpp:
• html/parser/HTMLTreeBuilder.cpp:
• inspector/InspectorProfilerAgent.cpp:
• loader/icon/IconDatabase.cpp:
• page/Chrome.cpp:
• page/Navigator.cpp:
• page/Page.cpp:
• plugins/PluginView.cpp:
• plugins/gtk/PluginViewGtk.cpp:
• plugins/qt/PluginViewQt.cpp:
• plugins/symbian/PluginViewSymbian.cpp:
• plugins/win/PluginViewWin.cpp:
• svg/SVGDocumentExtensions.cpp:
• xml/XMLTreeViewer.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSCustomPositionCallback.cpp (modified) (1 diff)
• bindings/js/JSCustomPositionErrorCallback.cpp (modified) (1 diff)
• bindings/js/JSCustomVoidCallback.cpp (modified) (1 diff)
• bindings/js/JSCustomXPathNSResolver.cpp (modified) (1 diff)
• bindings/js/JSDOMWindowBase.cpp (modified) (1 diff)
• bindings/js/JSDOMWindowShell.cpp (modified) (1 diff)
• bindings/js/JSDocumentCustom.cpp (modified) (1 diff)
• bindings/js/ScriptDebugServer.cpp (modified) (1 diff)
• bindings/v8/NPV8Object.cpp (modified) (1 diff)
• bindings/v8/ScriptCachedFrameData.cpp (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (1 diff)
• bindings/v8/V8DOMWrapper.cpp (modified) (1 diff)
• bindings/v8/V8IsolatedContext.cpp (modified) (1 diff)
• bindings/v8/V8Proxy.cpp (modified) (1 diff)
• bindings/v8/custom/V8LocationCustom.cpp (modified) (1 diff)
• dom/Node.cpp (modified) (1 diff)
• dom/ScriptElement.cpp (modified) (1 diff)
• dom/XMLDocumentParser.cpp (modified) (1 diff)
• dom/XMLDocumentParserQt.cpp (modified) (1 diff)
• html/HTMLEmbedElement.cpp (modified) (1 diff)
• html/HTMLObjectElement.cpp (modified) (1 diff)
• html/HTMLPlugInElement.cpp (modified) (1 diff)
• html/parser/HTMLConstructionSite.cpp (modified) (1 diff)
• html/parser/HTMLTreeBuilder.cpp (modified) (1 diff)
• inspector/InspectorProfilerAgent.cpp (modified) (1 diff)
• loader/icon/IconDatabase.cpp (modified) (1 diff)
• page/Chrome.cpp (modified) (1 diff)
• page/Navigator.cpp (modified) (1 diff)
• page/Page.cpp (modified) (1 diff)
• plugins/PluginView.cpp (modified) (1 diff)
• plugins/gtk/PluginViewGtk.cpp (modified) (1 diff)
• plugins/qt/PluginViewQt.cpp (modified) (1 diff)
• plugins/symbian/PluginViewSymbian.cpp (modified) (1 diff)
• plugins/win/PluginViewWin.cpp (modified) (1 diff)
• svg/SVGDocumentExtensions.cpp (modified) (1 diff)
• xml/XMLTreeViewer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-19  Mihai Parparita  <mihaip@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        ScriptController.h is included in too many places
+        https://bugs.webkit.org/show_bug.cgi?id=58963
+
+        Remove ScriptController.h #includes from a bunch of .cpp files where it
+        doesn't appear to be necessary.
+
+        * bindings/js/JSCustomPositionCallback.cpp:
+        * bindings/js/JSCustomPositionErrorCallback.cpp:
+        * bindings/js/JSCustomVoidCallback.cpp:
+        * bindings/js/JSCustomXPathNSResolver.cpp:
+        * bindings/js/JSDOMWindowBase.cpp:
+        * bindings/js/JSDOMWindowShell.cpp:
+        * bindings/js/JSDocumentCustom.cpp:
+        * bindings/js/ScriptDebugServer.cpp:
+        * bindings/v8/NPV8Object.cpp:
+        * bindings/v8/ScriptCachedFrameData.cpp:
+        * bindings/v8/V8DOMWindowShell.cpp:
+        * bindings/v8/V8DOMWrapper.cpp:
+        * bindings/v8/V8IsolatedContext.cpp:
+        * bindings/v8/V8Proxy.cpp:
+        * bindings/v8/custom/V8LocationCustom.cpp:
+        * dom/Node.cpp:
+        * dom/ScriptElement.cpp:
+        * dom/XMLDocumentParser.cpp:
+        * dom/XMLDocumentParserQt.cpp:
+        * html/HTMLEmbedElement.cpp:
+        * html/HTMLObjectElement.cpp:
+        * html/HTMLPlugInElement.cpp:
+        * html/parser/HTMLConstructionSite.cpp:
+        * html/parser/HTMLTreeBuilder.cpp:
+        * inspector/InspectorProfilerAgent.cpp:
+        * loader/icon/IconDatabase.cpp:
+        * page/Chrome.cpp:
+        * page/Navigator.cpp:
+        * page/Page.cpp:
+        * plugins/PluginView.cpp:
+        * plugins/gtk/PluginViewGtk.cpp:
+        * plugins/qt/PluginViewQt.cpp:
+        * plugins/symbian/PluginViewSymbian.cpp:
+        * plugins/win/PluginViewWin.cpp:
+        * svg/SVGDocumentExtensions.cpp:
+        * xml/XMLTreeViewer.cpp:
+
 2011-04-20  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/bindings/js/JSCustomPositionCallback.cpp

@@ -31 +31 @@
 #include "Frame.h"
 #include "JSGeoposition.h"
-#include "ScriptController.h"
 #include <runtime/JSLock.h>
 

trunk/Source/WebCore/bindings/js/JSCustomPositionErrorCallback.cpp

@@ -31 +31 @@
 #include "Frame.h"
 #include "JSPositionError.h"
-#include "ScriptController.h"
 #include <runtime/JSLock.h>
 

trunk/Source/WebCore/bindings/js/JSCustomVoidCallback.cpp

@@ -33 +33 @@
 #include "JSCallbackData.h"
 #include "JSDOMWindowCustom.h"
-#include "ScriptController.h"
 #include <runtime/JSLock.h>
 #include <wtf/MainThread.h>

trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp

@@ -33 +33 @@
 #include "Frame.h"
 #include "JSDOMWindowCustom.h"
-#include "ScriptController.h"
 #include <runtime/JSLock.h>
 

trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp

@@ -33 +33 @@
 #include "Logging.h"
 #include "Page.h"
-#include "ScriptController.h"
 #include "SecurityOrigin.h"
 #include "Settings.h"

trunk/Source/WebCore/bindings/js/JSDOMWindowShell.cpp

@@ -33 +33 @@
 #include "JSDOMWindow.h"
 #include "DOMWindow.h"
-#include "ScriptController.h"
 #include <runtime/JSObject.h>
 

trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp

@@ -35 +35 @@
 #include "JSTouchList.h"
 #include "Location.h"
-#include "ScriptController.h"
 #include "TouchList.h"
 

trunk/Source/WebCore/bindings/js/ScriptDebugServer.cpp

@@ -37 +37 @@
 #include "JavaScriptCallFrame.h"
 #include "ScriptBreakpoint.h"
-#include "ScriptController.h"
 #include "ScriptDebugListener.h"
 #include <debugger/DebuggerCallFrame.h>

trunk/Source/WebCore/bindings/v8/NPV8Object.cpp

@@ -34 +34 @@
 #include "OwnArrayPtr.h"
 #include "PlatformString.h"
-#include "ScriptController.h"
 #include "UserGestureIndicator.h"
 #include "V8GCController.h"

trunk/Source/WebCore/bindings/v8/ScriptCachedFrameData.cpp

@@ -32 +32 @@
 
 #include "Frame.h"
-#include "ScriptController.h"
 #include "V8DOMWindow.h"
 

trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -43 +43 @@
 #include "ScriptCallStack.h"
 #include "ScriptCallStackFactory.h"
-#include "ScriptController.h"
 #include "ScriptProfiler.h"
 #include "StorageNamespace.h"

trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp

@@ -37 +37 @@
 #include "FrameLoaderClient.h"
 #include "Notification.h"
-#include "ScriptController.h"
 #include "V8AbstractEventListener.h"
 #include "V8Binding.h"

trunk/Source/WebCore/bindings/v8/V8IsolatedContext.cpp

@@ -36 +36 @@
 #include "FrameLoaderClient.h"
 #include "HashMap.h"
-#include "ScriptController.h"
 #include "V8DOMWindow.h"
 #include "V8HiddenPropertyName.h"

trunk/Source/WebCore/bindings/v8/V8Proxy.cpp

@@ -45 +45 @@
 #include "PageGroup.h"
 #include "PlatformBridge.h"
-#include "ScriptController.h"
 #include "Settings.h"
 #include "StorageNamespace.h"

trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp

@@ -38 +38 @@
 #include "Location.h"
 #include "PlatformString.h"
-#include "ScriptController.h"
 #include "V8Binding.h"
 #include "V8BindingState.h"

trunk/Source/WebCore/dom/Node.cpp

@@ -76 +76 @@
 #include "RenderView.h"
 #include "ScopedEventQueue.h"
-#include "ScriptController.h"
 #include "SelectorNodeList.h"
 #include "StaticNodeList.h"

trunk/Source/WebCore/dom/ScriptElement.cpp

@@ -37 +37 @@
 #include "MIMETypeRegistry.h"
 #include "Page.h"
-#include "ScriptController.h"
 #include "ScriptRunner.h"
 #include "ScriptSourceCode.h"

trunk/Source/WebCore/dom/XMLDocumentParser.cpp

@@ -46 +46 @@
 #include "ResourceRequest.h"
 #include "ResourceResponse.h"
-#include "ScriptController.h"
 #include "ScriptElement.h"
 #include "ScriptSourceCode.h"

trunk/Source/WebCore/dom/XMLDocumentParserQt.cpp

@@ -48 +48 @@
 #include "ResourceResponse.h"
 #include "ScriptableDocumentParser.h"
-#include "ScriptController.h"
 #include "ScriptElement.h"
 #include "ScriptSourceCode.h"

trunk/Source/WebCore/html/HTMLEmbedElement.cpp

@@ -39 +39 @@
 #include "RenderImage.h"
 #include "RenderWidget.h"
-#include "ScriptController.h"
 #include "Settings.h"
 

trunk/Source/WebCore/html/HTMLObjectElement.cpp

@@ -40 +40 @@
 #include "RenderImage.h"
 #include "RenderWidget.h"
-#include "ScriptController.h"
 #include "ScriptEventListener.h"
 #include "Text.h"

trunk/Source/WebCore/html/HTMLPlugInElement.cpp

@@ -36 +36 @@
 #include "RenderEmbeddedObject.h"
 #include "RenderWidget.h"
-#include "ScriptController.h"
 #include "Settings.h"
 #include "Widget.h"

trunk/Source/WebCore/html/parser/HTMLConstructionSite.cpp

@@ -49 +49 @@
 #include "SVGNames.h"
 #endif
-#include "ScriptController.h"
 #include "Settings.h"
 #include "Text.h"

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -47 +47 @@
 #include "NotImplemented.h"
 #include "SVGNames.h"
-#include "ScriptController.h"
 #include "Text.h"
 #include "XLinkNames.h"

trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp

@@ -42 +42 @@
 #include "Page.h"
 #include "PageScriptDebugServer.h"
-#include "ScriptController.h"
 #include "ScriptHeapSnapshot.h"
 #include "ScriptProfile.h"

trunk/Source/WebCore/loader/icon/IconDatabase.cpp

@@ -37 +37 @@
 #include "IntSize.h"
 #include "Logging.h"
-#include "ScriptController.h"
 #include "SQLiteStatement.h"
 #include "SQLiteTransaction.h"

trunk/Source/WebCore/page/Chrome.cpp

@@ -39 +39 @@
 #include "RenderObject.h"
 #include "ResourceHandle.h"
-#include "ScriptController.h"
 #include "SecurityOrigin.h"
 #include "Settings.h"

trunk/Source/WebCore/page/Navigator.cpp

@@ -41 +41 @@
 #include "PlatformString.h"
 #include "PluginData.h"
-#include "ScriptController.h"
 #include "Settings.h"
 #include "StorageNamespace.h"

trunk/Source/WebCore/page/Page.cpp

@@ -62 +62 @@
 #include "RenderWidget.h"
 #include "RuntimeEnabledFeatures.h"
-#include "ScriptController.h"
 #include "SelectionController.h"
 #include "Settings.h"

trunk/Source/WebCore/plugins/PluginView.cpp

@@ -60 +60 @@
 #include "RenderBox.h"
 #include "RenderObject.h"
-#include "ScriptController.h"
 #include "ScriptValue.h"
 #include "SecurityOrigin.h"

trunk/Source/WebCore/plugins/gtk/PluginViewGtk.cpp

@@ -59 +59 @@
 #include "Settings.h"
 #include "JSDOMBinding.h"
-#include "ScriptController.h"
 #include "npruntime_impl.h"
 #include "runtime_root.h"

trunk/Source/WebCore/plugins/qt/PluginViewQt.cpp

@@ -65 +65 @@
 #include "QWebPageClient.h"
 #include "RenderLayer.h"
-#include "ScriptController.h"
 #include "Settings.h"
 #include "npruntime_impl.h"

trunk/Source/WebCore/plugins/symbian/PluginViewSymbian.cpp

@@ -48 +48 @@
 #include "QWebPageClient.h"
 #include "RenderLayer.h"
-#include "ScriptController.h"
 #include "Settings.h"
 #include "npfunctions.h"

trunk/Source/WebCore/plugins/win/PluginViewWin.cpp

@@ -62 +62 @@
 #include "PluginPackage.h"
 #include "RenderWidget.h"
-#include "ScriptController.h"
 #include "Settings.h"
 #include "WebCoreInstanceHandle.h"

trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp

@@ -36 +36 @@
 #include "SVGSMILElement.h"
 #include "SVGSVGElement.h"
-#include "ScriptController.h"
 #include "ScriptableDocumentParser.h"
 #include <wtf/text/AtomicString.h>

trunk/Source/WebCore/xml/XMLTreeViewer.cpp

@@ -36 +36 @@
 #include "Frame.h"
 #include "Page.h"
-#include "ScriptController.h"
 #include "ScriptSourceCode.h"
 #include "Settings.h"