Changeset 84405 in webkit

Timestamp:

Apr 20, 2011 12:21:59 PM (13 years ago)

Author:

ojan@chromium.org

Message:

2011-04-20 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

add expandAll/collapseAll links
​https://bugs.webkit.org/show_bug.cgi?id=59011

• Scripts/webkitpy/layout_tests/layout_package/json_results.html:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/layout_package/json_results.html (modified) (6 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-04-20  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        add expandAll/collapseAll links
+        https://bugs.webkit.org/show_bug.cgi?id=59011
+
+        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
+
 2011-04-20  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html

@@ -158 +158 @@
 }
 
-function expandExpectations(e)
+function toggleExpectations(e)
 {
     var expandLink = e.target;
@@ -164 +164 @@
         expandLink = expandLink.querySelector('.expand-button-text');
 
-    var isExpand = expandLink.textContent == '+';
+    if (expandLink.textContent == '+')
+        expandExpectations(expandLink);
+    else
+        collapseExpectations(expandLink);
+}
+
+function collapseExpectations(expandLink)
+{
+    expandLink.textContent = '+';
+    var existingResultsRow = parentOfType(expandLink, 'tbody').querySelector('.results-row');
+    if (existingResultsRow)
+        existingResultsRow.style.display = 'none';
+}
+
+function expandExpectations(expandLink)
+{
     var row = parentOfType(expandLink, 'tr');
     var parentTbody = row.parentNode;
     var existingResultsRow = parentTbody.querySelector('.results-row');
-    
-    if (!isExpand) {
-        expandLink.textContent = '+';
-        existingResultsRow.style.display = 'none';
-        return;
-    }
     
     var enDash = '\u2013';
@@ -197 +206 @@
 }
 
+function expandAllExpectations()
+{
+    var expandLinks = document.querySelectorAll('.expand-button-text');
+    for (var i = 0; len = expandLinks.length; i++)
+        expandExpectations(expandLinks[i]);
+}
+
+function collapseAllExpectations()
+{
+    var expandLinks = document.querySelectorAll('.expand-button-text');
+    for (var i = 0; len = expandLinks.length; i++)
+        collapseExpectations(expandLinks[i]);
+}
+
 function testLink(test)
 {
@@ -204 +227 @@
     else
         basePath = 'http://trac.webkit.org/browser/trunk/LayoutTests/';
-    return '<span class=expand-button onclick="expandExpectations(event)"><span class=expand-button-text>+</span></span>' +
+    return '<span class=expand-button onclick="toggleExpectations(event)"><span class=expand-button-text>+</span></span>' +
         '<a class=test-link href="' + basePath + test + '">' + test + '</a>';
 }
@@ -303 +326 @@
 }
 
-var html = '';
+var html = '<div id=options>' +
+    '<a href="javascript:void()" class="expand-all" onclick="expandAllExpectations()">expand all</a> ' +
+    '<a href="javascript:void()" class="collapse-all" onclick="collapseAllExpectations()">collapse all</a>';
+
 if (g_results.uses_expectations_file)
-    html += '<div id=options><label><input class="unexpected-results" type=checkbox checked>Only show unexpected results</label></div>';
+    html += '<label><input class="unexpected-results" type=checkbox checked onchange="updateExpectedResults()">Only show unexpected results</label>';
+
+html += '</div>';
 
 var tableRowsHtml = tableRows();
@@ -546 +574 @@
 
 updateExpectedResults();
-if (document.querySelector('.unexpected-results'))
-    document.querySelector('.unexpected-results').addEventListener('change', updateExpectedResults, false);
 
 if (!g_hasTextFailures)