Changeset 84455 in webkit
- Timestamp:
- Apr 20, 2011 7:20:17 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r84453 r84455 1 2011-04-20 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r84431. 4 http://trac.webkit.org/changeset/84431 5 https://bugs.webkit.org/show_bug.cgi?id=59061 6 7 Breaks for folks who don't have editbugs (Requested by abarth 8 on #webkit). 9 10 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: 11 * Scripts/webkitpy/tool/commands/upload_unittest.py: 12 * Scripts/webkitpy/tool/mocktool.py: 13 * Scripts/webkitpy/tool/steps/postdiff.py: 14 1 15 2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn> 2 16 -
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
r84431 r84455 737 737 self.browser.submit() 738 738 739 def reassign_bug(self, bug_id, assignee=None, comment_text=None): 740 self.authenticate() 741 742 if not assignee: 743 assignee = self.username 739 def reassign_bug(self, bug_id, assignee, comment_text=None): 740 self.authenticate() 744 741 745 742 log("Assigning bug %s to %s" % (bug_id, assignee)) -
trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py
r84431 r84455 43 43 def test_assign_to_committer(self): 44 44 tool = MockTool() 45 expected_stderr = """Warning, attachment 128 on bug 42 has invalid committer (non-committer@example.com) 46 MOCK reassign_bug: bug_id=42, assignee=eric@webkit.org 47 -- Begin comment -- 48 Attachment 128 was posted by a committer and has review+, assigning to Eric Seidel for commit. 49 -- End comment -- 50 Bug 77 is already assigned to foo@foo.com (None). 51 Bug 76 has no non-obsolete patches, ignoring. 52 """ 45 expected_stderr = "Warning, attachment 128 on bug 42 has invalid committer (non-committer@example.com)\nBug 77 is already assigned to foo@foo.com (None).\nBug 76 has no non-obsolete patches, ignoring.\n" 53 46 self.assert_execute_outputs(AssignToCommitter(), [], expected_stderr=expected_stderr, tool=tool) 47 tool.bugs.reassign_bug.assert_called_with(42, "eric@webkit.org", "Attachment 128 was posted by a committer and has review+, assigning to Eric Seidel for commit.") 54 48 55 49 def test_obsolete_attachments(self): … … 69 63 Was that diff correct? 70 64 Obsoleting 2 old patches on bug 42 71 MOCK reassign_bug: bug_id=42, assignee=None72 65 MOCK add_patch_to_bug: bug_id=42, description=MOCK description, mark_for_review=True, mark_for_commit_queue=False, mark_for_landing=False 73 66 MOCK: user.open_url: http://example.com/42 … … 117 110 Was that diff correct? 118 111 Obsoleting 2 old patches on bug 42 119 MOCK reassign_bug: bug_id=42, assignee=None120 112 MOCK add_patch_to_bug: bug_id=42, description=MOCK description, mark_for_review=True, mark_for_commit_queue=False, mark_for_landing=False 121 113 MOCK: user.open_url: http://example.com/42 -
trunk/Tools/Scripts/webkitpy/tool/mocktool.py
r84431 r84455 330 330 return "%s/%s%s" % (self.bug_server_url, attachment_id, action_param) 331 331 332 def reassign_bug(self, bug_id, assignee=None, comment_text=None):333 log("MOCK reassign_bug: bug_id=%s, assignee=%s" % (bug_id, assignee))334 if comment_text:335 log("-- Begin comment --")336 log(comment_text)337 log("-- End comment --")338 339 332 def set_flag_on_attachment(self, 340 333 attachment_id, -
trunk/Tools/Scripts/webkitpy/tool/steps/postdiff.py
r84431 r84455 46 46 description = self._options.description or "Patch" 47 47 comment_text = self._options.comment 48 bug_id = state["bug_id"] 49 50 # FIXME: We should find some way of caching the Bug object instead of 51 # going back to the network here. 52 if self._tool.bugs.fetch_bug(bug_id).is_unassigned(): 53 self._tool.bugs.reassign_bug(bug_id) 54 55 self._tool.bugs.add_patch_to_bug(bug_id, diff, description, comment_text=comment_text, mark_for_review=self._options.review, mark_for_commit_queue=self._options.request_commit) 48 self._tool.bugs.add_patch_to_bug(state["bug_id"], diff, description, comment_text=comment_text, mark_for_review=self._options.review, mark_for_commit_queue=self._options.request_commit) 56 49 if self._options.open_bug: 57 self._tool.user.open_url(self._tool.bugs.bug_url_for_bug_id( bug_id))50 self._tool.user.open_url(self._tool.bugs.bug_url_for_bug_id(state["bug_id"]))
Note: See TracChangeset
for help on using the changeset viewer.