Changeset 84493 in webkit

Timestamp:

Apr 21, 2011 6:48:14 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2011-04-21 Pavel Feldman <​pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: following Image URL link in the network panel does nothing.
​https://bugs.webkit.org/show_bug.cgi?id=59092

• inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
• inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ImageView.js (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-04-21  Pavel Feldman  <pfeldman@google.com>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: following Image URL link in the network panel does nothing.
+        https://bugs.webkit.org/show_bug.cgi?id=59092
+
+        * inspector/front-end/ImageView.js:
+        (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
+        (WebInspector.ImageView.prototype._createContentIfNeeded):
+        * inspector/front-end/inspector.js:
+        (WebInspector.linkifyURLAsNode):
+
 2011-04-21  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/inspector/front-end/ImageView.js

@@ -100 +100 @@
             infoListElement.appendChild(dt);
             var dd = document.createElement("dd");
-            dd.appendChild(WebInspector.linkifyURLAsNode(this.resource.url));
+            var externalResource = true;
+            dd.appendChild(WebInspector.linkifyURLAsNode(this.resource.url, null, null, externalResource));
             infoListElement.appendChild(dd);
 

trunk/Source/WebCore/inspector/front-end/inspector.js

@@ -1301 +1301 @@
     a.textContent = linkText;
     a.style.maxWidth = "100%";
+    if (isExternal)
+        a.setAttribute("target", "_blank");
 
     return a;