Changeset 84499 in webkit


Ignore:
Timestamp:
Apr 21, 2011 7:59:35 AM (13 years ago)
Author:
caseq@chromium.org
Message:

2011-04-20 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
​https://bugs.webkit.org/show_bug.cgi?id=59006

  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionSidebarPane.prototype.setExpression):

2011-04-20 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Expose console API to the code evaluated by sidebar.setExpression()

Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
​https://bugs.webkit.org/show_bug.cgi?id=59006

  • inspector/extensions/extensions-expected.txt:
  • inspector/extensions/extensions.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r84496 r84499  
     12011-04-20  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Expose console API to the code evaluated by sidebar.setExpression()
     6
     7        Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
     8        https://bugs.webkit.org/show_bug.cgi?id=59006
     9
     10        * inspector/extensions/extensions-expected.txt:
     11        * inspector/extensions/extensions.html:
     12
    1132011-04-21  Tony Gentilcore  <tonyg@chromium.org>
    214

  • trunk/LayoutTests/inspector/extensions/extensions-expected.txt

    r82832 r84499  
    3333}
    3434RUNNING TEST: extension_testSidebarWatchExpression
    35 Sidebar content: titlef0: "expression"f1: undefinedf2: nullf3: Objectf4: Array[0]f5: Array[3]f6: Objectf7: 42f8: Locationf9: HTMLCollection[2]f10: function () {}__proto__: Object
     35Sidebar content: titlef0: "expression"f1: undefinedf2: nullf3: Objectf4: Array[0]f5: Array[3]f6: Objectf7: 42f8: Locationf9: HTMLCollection[2]f10: function () {}f11: "foo"__proto__: Object
    3636RUNNING TEST: extension_testSidebarWatchObject
    3737Watch sidebar created, callback arguments dump follows:

  • trunk/LayoutTests/inspector/extensions/extensions.html

    r82814 r84499  
    6161        function expression()
    6262        {
     63            document.body.testProperty = 'foo';
     64            inspect(document.body);
    6365            return {
    6466                f0: 'expression',
    … …  
    7274                f8: window.location,
    7375                f9: document.body.children,
    74                 f10: function() {}
     76                f10: function() {},
     77                f11: $0.testProperty
    7578            };
    7679        }

  • trunk/Source/WebCore/ChangeLog

    r84498 r84499  
     12011-04-20  Andrey Kosyakov  <caseq@chromium.org>
     2
     3        Reviewed by Pavel Feldman.
     4
     5        Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
     6        https://bugs.webkit.org/show_bug.cgi?id=59006
     7
     8        * inspector/front-end/ExtensionPanel.js:
     9        (WebInspector.ExtensionSidebarPane.prototype.setExpression):
     10
    1112011-04-21  Nikolas Zimmermann  <nzimmermann@rim.com>
    212

  • trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js

    r82814 r84499  
    9696    setExpression: function(expression, title)
    9797    {
    98         RuntimeAgent.evaluate(expression, "extension-watch", false, this._onEvaluate.bind(this, title));
     98        RuntimeAgent.evaluate(expression, "extension-watch", true, this._onEvaluate.bind(this, title));
    9999    },
    100100
Note: See TracChangeset for help on using the changeset viewer.